Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1543043003: Fix an infinite loop in CPDF_Parser::RebuildCrossRef(). (Closed)

Created:
5 years ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com, kcc2
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix an infinite loop in CPDF_Parser::RebuildCrossRef(). BUG=pdfium:325 R=weili@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2d88e91ca5538470c9f4bc098e7f1f1ea9013c37

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : fix #

Patch Set 5 : add tests #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -16 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 2 3 4 5 6 chunks +24 lines, -16 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A testing/resources/bug_325_a.pdf View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
A testing/resources/bug_325_b.pdf View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
5 years ago (2015-12-23 02:20:03 UTC) #2
Wei Li
https://codereview.chromium.org/1543043003/diff/20001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right): https://codereview.chromium.org/1543043003/diff/20001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#newcode964 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:964: break; I think bOverFlow means overflow to the next ...
4 years, 11 months ago (2015-12-30 20:32:39 UTC) #3
Lei Zhang
https://codereview.chromium.org/1543043003/diff/20001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right): https://codereview.chromium.org/1543043003/diff/20001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#newcode964 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:964: break; On 2015/12/30 20:32:39, Wei Li wrote: > I ...
4 years, 11 months ago (2016-01-05 06:08:39 UTC) #4
Lei Zhang
And since kcc@ said it was ok, I added a couple of the test cases ...
4 years, 11 months ago (2016-01-05 06:20:15 UTC) #5
Wei Li
On 2016/01/05 06:20:15, Lei Zhang wrote: > And since kcc@ said it was ok, I ...
4 years, 11 months ago (2016-01-05 18:20:29 UTC) #6
Lei Zhang
4 years, 11 months ago (2016-01-05 23:27:42 UTC) #8
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
2d88e91ca5538470c9f4bc098e7f1f1ea9013c37 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698