Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 1543003: - Fix V8 for FreeBSD & OpenBSD on i386 (32-bit), same ABI as Mac... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by Peter Valchev
Modified:
5 years, 3 months ago
CC:
v8-dev, evanm_chromium.org
Visibility:
Public.

Description

- Fix V8 for FreeBSD & OpenBSD on i386 (32-bit), same ABI as Mac - FreeBSD GYP changes based on work by sprewell@jaggeri.com

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M src/globals.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 3 chunks +20 lines, -1 line 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 5 (0 generated)
Peter Valchev
6 years, 5 months ago (2010-03-30 04:37:50 UTC) #1
Evan Martin
This seems good to me, but I don't know a lot about v8. CC'ing ager ...
6 years, 5 months ago (2010-03-30 13:51:42 UTC) #2
Erik Corry
LGTM http://codereview.chromium.org/1543003/diff/5001/6003 File src/globals.h (right): http://codereview.chromium.org/1543003/diff/5001/6003#newcode117 src/globals.h:117: #define USING_OTHER_ABI I dislike this name. Given that ...
6 years, 5 months ago (2010-03-31 21:30:20 UTC) #3
Peter Valchev
Thanks Erik. It turns out the instructions I followed to send a v8 patch created ...
6 years, 4 months ago (2010-04-01 15:50:43 UTC) #4
Erik Corry
6 years, 4 months ago (2010-04-06 12:16:59 UTC) #5
Committed to bleeding edge.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e15fb99