test/cctest/test-heap-profiler.cc - Issue 1542963002: [runtime] Introduce dedicated JSBoundFunction to represent bound functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 1542963002: [runtime] Introduce dedicated JSBoundFunction to represent bound functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@FunctionConstructor

Patch Set: [arm64] Poke does not preserve flags with --debug-code. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index 4c5bd30aad881efdef1f75cfacd6ae2063bec28f..a2fd09e9f59d4edd27b4c6ca1c0b3800648e8729 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -251,7 +251,7 @@ TEST(BoundFunctionInSnapshot) {

GetProperty(f, v8::HeapGraphEdge::kInternal, "bindings");

CHECK(bindings);

CHECK_EQ(v8::HeapGraphNode::kArray, bindings->GetType());

- CHECK_EQ(3, bindings->GetChildrenCount());

+ CHECK_EQ(1, bindings->GetChildrenCount());

const v8::HeapGraphNode* bound_this = GetProperty(

f, v8::HeapGraphEdge::kShortcut, "bound_this");

« no previous file with comments | « test/cctest/test-api.cc ('k') | test/mjsunit/function-bind.js » ('j') | no next file with comments »