Chromium Code Reviews| Index: src/json-stringifier.h |
| diff --git a/src/json-stringifier.h b/src/json-stringifier.h |
| index 400ec94e6f30feb0461d873cb01d88dc6bcf88ba..930a52b82cc04df29d480ef64658b8cb10109827 100644 |
| --- a/src/json-stringifier.h |
| +++ b/src/json-stringifier.h |
| @@ -337,14 +337,13 @@ BasicJsonStringifier::Result BasicJsonStringifier::Serialize_( |
| case JS_VALUE_TYPE: |
| if (deferred_string_key) SerializeDeferredKey(comma, key); |
| return SerializeJSValue(Handle<JSValue>::cast(object)); |
| - case JS_FUNCTION_TYPE: |
| - return UNCHANGED; |
| default: |
| if (object->IsString()) { |
| if (deferred_string_key) SerializeDeferredKey(comma, key); |
| SerializeString(Handle<String>::cast(object)); |
| return SUCCESS; |
| } else if (object->IsJSObject()) { |
| + if (object->IsCallable()) break; |
|
Yang
2015/12/22 14:51:11
Shouldn't this simply return UNCHANGED (so that ca
Benedikt Meurer
2015/12/23 05:04:34
Indeed, good catch. Thanks.
|
| // Go to slow path for global proxy and objects requiring access checks. |
| if (object->IsAccessCheckNeeded() || object->IsJSGlobalProxy()) break; |
| if (deferred_string_key) SerializeDeferredKey(comma, key); |