chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java - Issue 1542943006: [Offline pages] Removing permission prompt when accessing offline page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

Issue 1542943006: [Offline pages] Removing permission prompt when accessing offline page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing a comment based on CR Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

index 3d83485d8bf2af8116bdbeb878bc0292285f43a5..16388f66d867f3caa4a2ab493bec7d0b5d2c4181 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

@@ -172,7 +172,7 @@ public class ExternalNavigationHandler {

// to Chrome. This check should happen for reloads, navigations, etc..., which is why

// it occurs before the subsequent blocks.

if (params.getUrl().startsWith("file:")

- && mDelegate.shouldRequestFileAccess(params.getTab())) {

+ && mDelegate.shouldRequestFileAccess(params.getUrl(), params.getTab())) {

mDelegate.startFileIntent(

intent, params.getReferrerUrl(), params.getTab(),

params.shouldCloseContentsOnOverrideUrlLoadingAndLaunchIntent());