Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3720)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Issue 1542943006: [Offline pages] Removing permission prompt when accessing offline page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
index 60a5d8242232e391eadfdb17d3817ef5edd1f3c7..e3bf2e5061882618515d824866b3030d5624d3dd 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
@@ -20,6 +20,7 @@ import android.test.mock.MockPackageManager;
import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.CommandLine;
+import org.chromium.base.PathUtils;
import org.chromium.chrome.browser.IntentHandler;
import org.chromium.chrome.browser.externalnav.ExternalNavigationHandler.OverrideUrlLoadingResult;
import org.chromium.chrome.browser.tab.Tab;
@@ -1144,6 +1145,20 @@ public class ExternalNavigationHandlerTest extends InstrumentationTestCase {
START_FILE);
}
+ @SmallTest
+ public void testOfflinePageAccess() {
+ String validOfflinePageUrl = "file://"
+ + PathUtils.getDataDirectory(getInstrumentation().getContext())
+ + "/Default/Offline%20Pages/archives/test.mhtml";
+
+ mDelegate.shouldRequestFileAccess = true;
+ // Verify no overrides if a valid offline page URL is provided.
+ check(validOfflinePageUrl, NO_REFERRER, NORMAL_PROFILE, PageTransition.LINK, NO_REDIRECT,
+ true, false, null, OverrideUrlLoadingResult.NO_OVERRIDE, IGNORE);
+ check(validOfflinePageUrl, NO_REFERRER, INCOGNITO_PROFILE, PageTransition.LINK, NO_REDIRECT,
+ true, false, null, OverrideUrlLoadingResult.NO_OVERRIDE, IGNORE);
+ }
+
private static class TestExternalNavigationDelegate implements ExternalNavigationDelegate {
private Context mContext;

Powered by Google App Engine
This is Rietveld 408576698