Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1542833003: Settings: Trivial fix for Basic page closure compile error. (Closed)

Created:
5 years ago by tommycli
Modified:
5 years ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Trivial fix for Basic page closure compile error. BUG=NONE Committed: https://crrev.com/c774f8f263b3fd7897e413ea3d7a9f41edfcbc4a Cr-Commit-Position: refs/heads/master@{#366505}

Patch Set 1 #

Patch Set 2 : add one more missing line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/resources/settings/basic_page/basic_page.js View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/basic_page/compiled_resources.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
tommycli
dpapad: PTAL
5 years ago (2015-12-22 00:04:50 UTC) #2
dpapad
lgtm
5 years ago (2015-12-22 00:11:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542833003/20001
5 years ago (2015-12-22 00:16:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-22 01:09:07 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-22 01:10:04 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c774f8f263b3fd7897e413ea3d7a9f41edfcbc4a
Cr-Commit-Position: refs/heads/master@{#366505}

Powered by Google App Engine
This is Rietveld 408576698