Move ReadyState enum from MediaControllerInterface to HTMLMediaElement

Move ReadyState enum from MediaControllerInterface to HTMLMediaElement

The spec for MediaController.readyState says "uses
HTMLMediaElement.readyState's values", so make it so in the
implementation as well.

This is a first step in reducing the size of MediaControllerInterface.

BUG=341852
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166764

[philipj_slow, 2014-02-07 13:25:37]

First of a series of patches to get MediaControllerInterface out of the way.

https://codereview.chromium.org/154283004/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.h (right):

https://codereview.chromium.org/154283004/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.h:121: enum ReadyState { HAVE_NOTHING,
HAVE_METADATA, HAVE_CURRENT_DATA, HAVE_FUTURE_DATA, HAVE_ENOUGH_DATA };
** Presubmit ERRORS **
check-webkit-style failed
  Source/core/html/HTMLMediaElement.h:121:  enum members should use InterCaps
with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 3 files

I think it would be silly to use HaveNothing here, what do you think Aaron? I'm
not sure how to bypass presubmit when using CQ if we want that, will I have to
dcommit?

[acolwell GONE FROM CHROMIUM, 2014-02-07 21:52:40]

lgtm. 

You might want to check w/ abarth whether there is a way to get the enum through
the CQ w/ the existing names.

https://codereview.chromium.org/154283004/diff/1/Source/core/html/MediaContro...
File Source/core/html/MediaController.cpp (right):

https://codereview.chromium.org/154283004/diff/1/Source/core/html/MediaContro...
Source/core/html/MediaController.cpp:334: static AtomicString
eventNameForReadyState(HTMLMediaElement::ReadyState state)
nit: If you make this a method, you shouldn't have to fully qualify everything.
Might we worth the reduction in visual clutter.

https://codereview.chromium.org/154283004/diff/1/Source/core/html/MediaContro...
File Source/core/html/MediaController.h (right):

https://codereview.chromium.org/154283004/diff/1/Source/core/html/MediaContro...
Source/core/html/MediaController.h:84: HTMLMediaElement::ReadyState readyState()
const { return m_readyState; }
Perhaps use "typedef HTMLMediaElement::ReadyState ReadyState;" here so we don't
have to explicitly call out HTMLMediaElement everywhere?

[philipj_slow, 2014-02-08 03:52:03]

https://codereview.chromium.org/154283004/diff/1/Source/core/html/MediaContro...
File Source/core/html/MediaController.cpp (right):

https://codereview.chromium.org/154283004/diff/1/Source/core/html/MediaContro...
Source/core/html/MediaController.cpp:334: static AtomicString
eventNameForReadyState(HTMLMediaElement::ReadyState state)
On 2014/02/07 21:52:40, acolwell wrote:
> nit: If you make this a method, you shouldn't have to fully qualify
everything.
> Might we worth the reduction in visual clutter.

The enum constants themselves still need to be prefixed, so that would be
switching HTMLMediaElement::ReadyState for
MediaController::eventNameForReadyState, I tried it and didn't think it was an
improvement. I noticed that the return value could be const AtomicString&
though, and made it so.

https://codereview.chromium.org/154283004/diff/1/Source/core/html/MediaContro...
File Source/core/html/MediaController.h (right):

https://codereview.chromium.org/154283004/diff/1/Source/core/html/MediaContro...
Source/core/html/MediaController.h:84: HTMLMediaElement::ReadyState readyState()
const { return m_readyState; }
On 2014/02/07 21:52:40, acolwell wrote:
> Perhaps use "typedef HTMLMediaElement::ReadyState ReadyState;" here so we
don't
> have to explicitly call out HTMLMediaElement everywhere?

Done.

[abarth-chromium, 2014-02-08 04:20:40]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-02-08 04:20:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/154283004/100001

[abarth-chromium, 2014-02-08 04:21:05]

On 2014/02/07 21:52:40, acolwell wrote:
> You might want to check w/ abarth whether there is a way to get the enum
through
> the CQ w/ the existing names.

The CQ doesn't run the style check, so it should be fine.

[philipj_slow, 2014-02-08 05:52:16]

On 2014/02/08 04:21:05, abarth wrote:
> On 2014/02/07 21:52:40, acolwell wrote:
> > You might want to check w/ abarth whether there is a way to get the enum
> through
> > the CQ w/ the existing names.
> 
> The CQ doesn't run the style check, so it should be fine.

Great! I guess I should have just tried it, I assumed blink_presubmit would
barf...

[commit-bot: I haz the power, 2014-02-08 06:13:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-08 06:13:49]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[philipj_slow, 2014-02-08 07:18:46]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-02-08 07:18:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/154283004/100001

[commit-bot: I haz the power, 2014-02-08 07:45:58]

Change committed as 166764