Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 154283003: Add more test cases for api function inlining (Closed)

Created:
6 years, 10 months ago by dcarney
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Add more test cases for api function inlining R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -15 lines) Patch
M test/cctest/test-api.cc View 6 chunks +40 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
ptal getters and setters with an api_holder on the hidden prototype chain cannot be inlined ...
6 years, 10 months ago (2014-02-07 12:05:05 UTC) #1
Toon Verwaest
lgtm
6 years, 10 months ago (2014-02-10 10:52:51 UTC) #2
dcarney
6 years, 10 months ago (2014-02-11 12:49:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19278 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698