Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1542813003: [debugger] step on every assignment in destructuring bind. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] step on every assignment in destructuring bind. R=caitpotter88@gmail.com, littledan@chromium.org Committed: https://crrev.com/b00d9e25bf56db656e01b0996b65c0883fd077dd Cr-Commit-Position: refs/heads/master@{#33009}

Patch Set 1 #

Patch Set 2 : fix: only emit statement positions for subpatterns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -8 lines) Patch
M src/parsing/parser.h View 1 3 chunks +4 lines, -0 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 4 chunks +12 lines, -8 lines 0 comments Download
A test/mjsunit/harmony/debug-step-destructuring-bind.js View 1 1 chunk +110 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Yang
5 years ago (2015-12-22 09:40:20 UTC) #1
Dan Ehrenberg
lgtm
5 years ago (2015-12-22 09:43:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542813003/1
5 years ago (2015-12-22 09:45:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/13489)
5 years ago (2015-12-22 09:59:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542813003/20001
5 years ago (2015-12-22 12:42:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-22 13:28:39 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-22 13:29:40 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b00d9e25bf56db656e01b0996b65c0883fd077dd
Cr-Commit-Position: refs/heads/master@{#33009}

Powered by Google App Engine
This is Rietveld 408576698