[RDHI] Refactored blocked_loaders_map_ to key by render frame route id

extensions/browser/app_window/app_window_contents.cc

Index: extensions/browser/app_window/app_window_contents.cc
diff --git a/extensions/browser/app_window/app_window_contents.cc b/extensions/browser/app_window/app_window_contents.cc
index 3419326f867c67d06df0d51c5bf462f8de4a8f41..e0f36a9e2924e71e30f234b527acee7b34bc0ef3 100644
--- a/extensions/browser/app_window/app_window_contents.cc
+++ b/extensions/browser/app_window/app_window_contents.cc
@@ -9,6 +9,7 @@
 
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/browser/loader_io_thread_notifier.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
@@ -89,14 +90,8 @@ void AppWindowContentsImpl::OnWindowReady() {
   is_window_ready_ = true;
   if (is_blocking_requests_) {
     is_blocking_requests_ = false;
-    content::RenderFrameHost* frame = web_contents_->GetMainFrame();
-    content::BrowserThread::PostTask(
-        content::BrowserThread::IO, FROM_HERE,
-        base::Bind(
-            &content::ResourceDispatcherHost::ResumeBlockedRequestsForRoute,
-            base::Unretained(content::ResourceDispatcherHost::Get()),
-            frame->GetProcess()->GetID(),
-            frame->GetRenderViewHost()->GetRoutingID()));
+    content::LoaderIOThreadNotifier::ResumeBlockedRequestsForFrame(
+        web_contents_->GetMainFrame());
   }
 }
 
@@ -136,14 +131,7 @@ void AppWindowContentsImpl::SuspendRenderFrameHost(
   if (is_window_ready_)
     return;
   is_blocking_requests_ = true;
-  // The ResourceDispatcherHost only accepts RenderViewHost child ids.
-  // TODO(devlin): This will need to change for site isolation.
-  content::BrowserThread::PostTask(
-      content::BrowserThread::IO, FROM_HERE,
-      base::Bind(&content::ResourceDispatcherHost::BlockRequestsForRoute,
-                 base::Unretained(content::ResourceDispatcherHost::Get()),
-                 rfh->GetProcess()->GetID(),
-                 rfh->GetRenderViewHost()->GetRoutingID()));
+  content::LoaderIOThreadNotifier::BlockRequestsForFrame(rfh);

[nasko, 2016/01/07 00:43:09]

Can we stick those methods on an existing class that is a bit easier to
understand? Looking from outside of content, I have very little idea what the
loader notifier is and shouldn't really care much that there is IO thread
involved in this.

Leaving the method on RDH seems better to me or even putting it on
RenderFrameHost itself.

[Charlie Harrison, 2016/01/07 22:47:06]

Yeah, I think I'll merge the LoaderIOThreadNotifier into RDHI.

 }
 
 }  // namespace extensions