Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: content/browser/renderer_host/render_widget_helper.cc

Issue 1542743002: [RDHI] Refactored blocked_loaders_map_ to key by render frame route id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_helper.cc
diff --git a/content/browser/renderer_host/render_widget_helper.cc b/content/browser/renderer_host/render_widget_helper.cc
index 93283733b31dd923c315c9054e9416caf22c1c73..cf06b3d6ca34068754ffe3865470a4736ed0ef14 100644
--- a/content/browser/renderer_host/render_widget_helper.cc
+++ b/content/browser/renderer_host/render_widget_helper.cc
@@ -82,17 +82,6 @@ void RenderWidgetHelper::ResumeDeferredNavigation(
request_id));
}
-void RenderWidgetHelper::ResumeRequestsForView(int route_id) {
- // We only need to resume blocked requests if we used a valid route_id.
- // See CreateNewWindow.
- if (route_id != MSG_ROUTING_NONE) {
- BrowserThread::PostTask(
- BrowserThread::IO, FROM_HERE,
- base::Bind(&RenderWidgetHelper::OnResumeRequestsForView,
- this, route_id));
- }
-}
-
void RenderWidgetHelper::OnResumeDeferredNavigation(
const GlobalRequestID& request_id) {
resource_dispatcher_host_->ResumeDeferredNavigation(request_id);
@@ -122,10 +111,10 @@ void RenderWidgetHelper::CreateNewWindow(
// should be updated to give the widget a distinct routing ID.
// https://crbug.com/545684
*main_frame_widget_route_id = *route_id;
- // Block resource requests until the view is created, since the HWND might
+ // Block resource requests until the frame is created, since the HWND might
// be needed if a response ends up creating a plugin.
- resource_dispatcher_host_->BlockRequestsForRoute(
- render_process_id_, *route_id);
+ resource_dispatcher_host_->BlockRequestsForFrame(
+ GlobalFrameRoutingId(render_process_id_, *main_frame_route_id));
Randy Smith (Not in Mondays) 2016/01/06 21:56:30 This is safe because at this point there will only
Charlie Harrison 2016/01/07 22:47:06 Done.
}
BrowserThread::PostTask(
@@ -149,11 +138,6 @@ void RenderWidgetHelper::OnCreateWindowOnUI(
session_storage_namespace);
}
-void RenderWidgetHelper::OnResumeRequestsForView(int route_id) {
- resource_dispatcher_host_->ResumeBlockedRequestsForRoute(
- render_process_id_, route_id);
-}
-
Randy Smith (Not in Mondays) 2016/01/06 21:56:30 When are the requests blocked above resumed?
Charlie Harrison 2016/01/07 22:47:06 Supplemented the comment above with this info.
void RenderWidgetHelper::CreateNewWidget(int opener_id,
blink::WebPopupType popup_type,
int* route_id) {

Powered by Google App Engine
This is Rietveld 408576698