[RDHI] Refactored blocked_loaders_map_ to key by render frame route id

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 1899 matching lines @@
 }
 
 bool RenderProcessHostImpl::SuddenTerminationAllowed() const {
   return sudden_termination_allowed_;
 }
 
 base::TimeDelta RenderProcessHostImpl::GetChildProcessIdleTime() const {
   return base::TimeTicks::Now() - child_process_activity_time_;
 }
 
-void RenderProcessHostImpl::ResumeRequestsForView(int route_id) {
-  widget_helper_->ResumeRequestsForView(route_id);
+void RenderProcessHostImpl::ResumeRequestsForFrame(int route_id) {

[Randy Smith (Not in Mondays), 2015/12/29 23:11:37]

I hope you were really careful about making sure this transformation propagated
up and down the callstack from here, since the compiler wouldn't have said a
word :-}.

[Charlie Harrison, 2015/12/30 20:51:49]

The approach I did here (and other places) was to change "ForRoute" or "ForView"
to "ForFrame", forcing all callers to change. I hoped that would catch all
cases, but your comment that the "compiler wouldn't have said a word" makes me
worried.

[Randy Smith (Not in Mondays), 2016/01/04 21:24:48]

No, actually, that sounds like a good approach.  Sorry to make you worried;
thanks for sketching out your method.

+  widget_helper_->ResumeRequestsForFrame(route_id);
 }
 
 void RenderProcessHostImpl::FilterURL(bool empty_allowed, GURL* url) {
   FilterURL(this, empty_allowed, url);
 }
 
 #if defined(ENABLE_WEBRTC)
 void RenderProcessHostImpl::EnableAudioDebugRecordings(
     const base::FilePath& file) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ skipping 823 matching lines @@
 void RenderProcessHostImpl::GetAudioOutputControllers(
     const GetAudioOutputControllersCallback& callback) const {
   audio_renderer_host()->GetOutputControllers(callback);
 }
 
 BluetoothDispatcherHost* RenderProcessHostImpl::GetBluetoothDispatcherHost() {
   return bluetooth_dispatcher_host_.get();
 }
 
 }  // namespace content