Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: runtime/bin/socket_patch.dart

Issue 154273003: Make std* blocking file-descriptors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update with bug. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/socket_macos.cc ('k') | runtime/bin/socket_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket_patch.dart
diff --git a/runtime/bin/socket_patch.dart b/runtime/bin/socket_patch.dart
index 56f04d16ac83f5e20daea12c422a37d3ca1feb92..d6ae4a78f4ca32830abdb0ff0ccd344a6ec887c9 100644
--- a/runtime/bin/socket_patch.dart
+++ b/runtime/bin/socket_patch.dart
@@ -964,10 +964,9 @@ class _RawSocket extends Stream<RawSocketEvent>
);
}
- factory _RawSocket._writePipe(int fd) {
+ factory _RawSocket._writePipe() {
var native = new _NativeSocket.pipe();
native.isClosedRead = true;
- if (fd != null) _getStdioHandle(native, fd);
return new _RawSocket(native);
}
@@ -1233,8 +1232,8 @@ class _Socket extends Stream<List<int>> implements Socket {
_raw.writeEventsEnabled = false;
}
- factory _Socket._writePipe([int fd]) {
- return new _Socket(new _RawSocket._writePipe(fd));
+ factory _Socket._writePipe() {
+ return new _Socket(new _RawSocket._writePipe());
}
factory _Socket._readPipe([int fd]) {
« no previous file with comments | « runtime/bin/socket_macos.cc ('k') | runtime/bin/socket_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698