Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1542683002: gn: Make command_buffer_gles2 deps less weird. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Make command_buffer_gles2 deps less weird. The target used to pull in source_sets that are part of the gpu component in component builds. This usually won't link well, so just depend on gpu directly. Happens to fix a build error in clang/win gn component builds too. BUG=82385 TBR=dpranke Committed: https://crrev.com/709d0def5bdd564e63b41d9b2ea67723dd2a1945 Cr-Commit-Position: refs/heads/master@{#366450}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M gpu/BUILD.gn View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Nico
Looks like hendrikw left chrome, so this is for you, sorry. This is a follow-up ...
5 years ago (2015-12-21 18:20:17 UTC) #2
Nico
I'll TBR this as it's simple and fixes a bot. Please do take a look ...
5 years ago (2015-12-21 20:20:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542683002/1
5 years ago (2015-12-21 20:20:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 20:25:36 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/709d0def5bdd564e63b41d9b2ea67723dd2a1945 Cr-Commit-Position: refs/heads/master@{#366450}
5 years ago (2015-12-21 20:26:23 UTC) #10
Dirk Pranke
5 years ago (2015-12-23 04:04:54 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698