Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1542633006: GN: Add assert that ash/BUILD.gn referenced only on supported platforms (Closed)

Created:
5 years ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Add assert that ash/BUILD.gn referenced only on supported platforms This helps to ensure that targets not supported on a platform are not included in the "all" target. BUG=None Committed: https://crrev.com/c9ff7c904410f4dd31b51eac92c67b4f40541fc0 Cr-Commit-Position: refs/heads/master@{#367472}

Patch Set 1 #

Patch Set 2 : switch to use_ash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ash/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
agrieve
4 years, 12 months ago (2015-12-23 19:58:25 UTC) #2
oshima
lgtm one nit: BUG=None (or file a bug if you're going make a lot of ...
4 years, 11 months ago (2016-01-04 21:45:37 UTC) #3
agrieve
On 2016/01/04 21:45:37, oshima wrote: > lgtm > > one nit: > > BUG=None (or ...
4 years, 11 months ago (2016-01-05 02:51:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542633006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542633006/20001
4 years, 11 months ago (2016-01-05 02:52:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-05 03:30:42 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 03:31:40 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9ff7c904410f4dd31b51eac92c67b4f40541fc0
Cr-Commit-Position: refs/heads/master@{#367472}

Powered by Google App Engine
This is Rietveld 408576698