Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1542633004: GN: Make enable_websockets and disable_file_support GN args (Closed)

Created:
5 years ago by agrieve
Modified:
5 years ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Make enable_websockets and disable_file_support GN args They need to be set when building cronet. BUG=462737 Committed: https://crrev.com/56240dfe17e12cdf54b302d6ed74bcc677bd785e Cr-Commit-Position: refs/heads/master@{#366669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M net/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
agrieve
5 years ago (2015-12-22 20:42:25 UTC) #2
mef
lgtm
5 years ago (2015-12-22 21:30:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542633004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542633004/1
5 years ago (2015-12-22 21:45:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 22:20:30 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-22 22:21:31 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/56240dfe17e12cdf54b302d6ed74bcc677bd785e
Cr-Commit-Position: refs/heads/master@{#366669}

Powered by Google App Engine
This is Rietveld 408576698