Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Issue 154263003: Pull gn binaries @ r248873 (Closed)

Created:
6 years, 10 months ago by brettw
Modified:
6 years, 10 months ago
Reviewers:
scottmg, Torne, blundell
CC:
chromium-reviews
Visibility:
Public.

Description

Pull gn binaries @ r248873 TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/gn/bin/linux/gn.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/linux/gn32.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/mac/gn.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/win/gn.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
brettw
Committed patchset #1 manually as r248912 (presubmit successful).
6 years, 10 months ago (2014-02-05 07:52:58 UTC) #1
Torne
Hi Brett, this binary appears not to have been built using the sysroot, so it ...
6 years, 10 months ago (2014-02-05 10:49:40 UTC) #2
blundell
Is this pull also the source of the android_aosp bustage at HEAD (e.g., http://build.chromium.org/p/chromium.linux/builders/Android%20Webview%20AOSP%20Builder/builds/8496/steps/gyp_webview/logs/stdio)? That ...
6 years, 10 months ago (2014-02-05 12:08:16 UTC) #3
Torne
On 2014/02/05 12:08:16, blundell wrote: > Is this pull also the source of the android_aosp ...
6 years, 10 months ago (2014-02-05 12:12:26 UTC) #4
blundell
I'm going to revert this patch to see if it fixes Android_AOSP. If it doesn't, ...
6 years, 10 months ago (2014-02-05 12:55:13 UTC) #5
blundell
A revert of this CL has been created in https://codereview.chromium.org/155713003/ by blundell@chromium.org. The reason for ...
6 years, 10 months ago (2014-02-05 12:57:12 UTC) #6
blundell
Revert failed to land with a weird error...I filed crbug.com/341023.
6 years, 10 months ago (2014-02-05 13:10:10 UTC) #7
brettw
Torne: Are you sure this is a sysroot problem? Do you have a link to ...
6 years, 10 months ago (2014-02-05 13:22:41 UTC) #8
Torne
On 2014/02/05 13:22:41, brettw wrote: > Torne: Are you sure this is a sysroot problem? ...
6 years, 10 months ago (2014-02-05 13:25:00 UTC) #9
Torne
6 years, 10 months ago (2014-02-05 13:25:01 UTC) #10
Message was sent while issue was closed.
On 2014/02/05 13:22:41, brettw wrote:
> Torne: Are you sure this is a sysroot problem? Do you have a link to the error
> or is it the "defined but not used" problem linked to by blundell?

Yes, we were definitely getting the same problem again:
2014-02-05
11:50:29:/automerger/android-src/external/chromium_org/tools/gn/bin/linux/gn:
/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.14' not found (required by
/automerger/android-src/external/chromium_org/tools/gn/bin/linux/gn)
2014-02-05
11:50:29:/automerger/android-src/external/chromium_org/tools/gn/bin/linux/gn:
/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.15' not found (required by
/automerger/android-src/external/chromium_org/tools/gn/bin/linux/gn)

This binary is compiled against glibc 2.15, not debian's 2.13.

That's unrelated to the build issue on the chrome waterfall, though.

Powered by Google App Engine
This is Rietveld 408576698