Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1542583003:
[proxies] Limit recursive proxy prototype lookups to 100'000 (Closed)
|
Created:
5 years ago by Camillo Bruni Modified:
5 years ago Reviewers:
Igor Sheludko CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[proxies] Limit recursive proxy prototype lookups to 100'000
Creating proto-recursive proxies might lead to instanceof while-looping
endlessly in Object::HasInPrototypeChain (For traps we already have stack
guards in place to prevent stack overflows). We prevent this by limiting
the number of proxies we visit in PrototypeIterator to a magic large number.
LOG=n
BUG=v8:1543
Committed: https://crrev.com/e10fdbed6d8b0ccbb3b4938bf6b3970b01cff2e8
Cr-Commit-Position: refs/heads/master@{#33007}
Patch Set 1 #Patch Set 2 : properly initialize instance var #
Total comments: 1
Patch Set 3 : adding constant and test #
Messages
Total messages: 24 (14 generated)
The CQ bit was checked by cbruni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542583003/1
cbruni@chromium.org changed reviewers: + ishell@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
Description was changed from ========== [proxies] Limit recursive prototype lookups to 1'000'000 Creating proto-recursive proxies might lead to instanceof looping endlessly. We prevent this by limiting the number of proxies we visit in PrototypeIterator to an magic large number. LOG=n BUG=v8:1534 ========== to ========== [proxies] Limit recursive prototype lookups to 1'000'000 Creating proto-recursive proxies might lead to instanceof while-looping endlessly (For traps we already have stack guards in place to prevent stack overflows). We prevent this by limiting the number of proxies we visit in PrototypeIterator to an magic large number. LOG=n BUG=v8:1534 ==========
The CQ bit was checked by cbruni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542583003/20001
lgtm with a nit: https://codereview.chromium.org/1542583003/diff/20001/src/prototype.h File src/prototype.h (right): https://codereview.chromium.org/1542583003/diff/20001/src/prototype.h#newcode139 src/prototype.h:139: if (seen_proxies_ > 1000000) { Please introduce a named constant for this.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [proxies] Limit recursive prototype lookups to 1'000'000 Creating proto-recursive proxies might lead to instanceof while-looping endlessly (For traps we already have stack guards in place to prevent stack overflows). We prevent this by limiting the number of proxies we visit in PrototypeIterator to an magic large number. LOG=n BUG=v8:1534 ========== to ========== [proxies] Limit recursive prototype lookups to 1'000'000 Creating proto-recursive proxies might lead to instanceof while-looping endlessly in Object::HasInPrototypeChain (For traps we already have stack guards in place to prevent stack overflows). We prevent this by limiting the number of proxies we visit in PrototypeIterator to a magic large number. LOG=n BUG=v8:1534 ==========
The CQ bit was checked by cbruni@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org Link to the patchset: https://codereview.chromium.org/1542583003/#ps40001 (title: "adding constant and test")
The CQ bit was unchecked by cbruni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542583003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542583003/40001
Description was changed from ========== [proxies] Limit recursive prototype lookups to 1'000'000 Creating proto-recursive proxies might lead to instanceof while-looping endlessly in Object::HasInPrototypeChain (For traps we already have stack guards in place to prevent stack overflows). We prevent this by limiting the number of proxies we visit in PrototypeIterator to a magic large number. LOG=n BUG=v8:1534 ========== to ========== [proxies] Limit recursive proxy prototype lookups to 100'000 Creating proto-recursive proxies might lead to instanceof while-looping endlessly in Object::HasInPrototypeChain (For traps we already have stack guards in place to prevent stack overflows). We prevent this by limiting the number of proxies we visit in PrototypeIterator to a magic large number. LOG=n BUG=v8:1534 ==========
The CQ bit was checked by cbruni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542583003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542583003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [proxies] Limit recursive proxy prototype lookups to 100'000 Creating proto-recursive proxies might lead to instanceof while-looping endlessly in Object::HasInPrototypeChain (For traps we already have stack guards in place to prevent stack overflows). We prevent this by limiting the number of proxies we visit in PrototypeIterator to a magic large number. LOG=n BUG=v8:1534 ========== to ========== [proxies] Limit recursive proxy prototype lookups to 100'000 Creating proto-recursive proxies might lead to instanceof while-looping endlessly in Object::HasInPrototypeChain (For traps we already have stack guards in place to prevent stack overflows). We prevent this by limiting the number of proxies we visit in PrototypeIterator to a magic large number. LOG=n BUG=v8:1534 Committed: https://crrev.com/e10fdbed6d8b0ccbb3b4938bf6b3970b01cff2e8 Cr-Commit-Position: refs/heads/master@{#33007} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e10fdbed6d8b0ccbb3b4938bf6b3970b01cff2e8 Cr-Commit-Position: refs/heads/master@{#33007}
Message was sent while issue was closed.
Description was changed from ========== [proxies] Limit recursive proxy prototype lookups to 100'000 Creating proto-recursive proxies might lead to instanceof while-looping endlessly in Object::HasInPrototypeChain (For traps we already have stack guards in place to prevent stack overflows). We prevent this by limiting the number of proxies we visit in PrototypeIterator to a magic large number. LOG=n BUG=v8:1534 Committed: https://crrev.com/e10fdbed6d8b0ccbb3b4938bf6b3970b01cff2e8 Cr-Commit-Position: refs/heads/master@{#33007} ========== to ========== [proxies] Limit recursive proxy prototype lookups to 100'000 Creating proto-recursive proxies might lead to instanceof while-looping endlessly in Object::HasInPrototypeChain (For traps we already have stack guards in place to prevent stack overflows). We prevent this by limiting the number of proxies we visit in PrototypeIterator to a magic large number. LOG=n BUG=v8:1543 Committed: https://crrev.com/e10fdbed6d8b0ccbb3b4938bf6b3970b01cff2e8 Cr-Commit-Position: refs/heads/master@{#33007} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
