Rewrite LayoutTest svg/wicd/rightsizing-grid as a reftest

Rewrite LayoutTest svg/wicd/rightsizing-grid as a reftest

A number of changes were made to reduce flakyness and make the test
more useful:

 * Rewrite as html reftest.

 * Apply a static body width. The test is no longer depending on the
   viewport width.

 * Use a slim body width. The way the test was written a lot of the
   test actually ended up outside the viewport. Layout tests use
   default size 800x600 and this test expected up to double the height
   compared to the width.

 * Avoid gradients and rounded rectangles since they add nothing to
   what's actually meant to be tested.

The test svg/wicd/sizing-flakiness.html is a subset of the
rightsizing-grid test and should provide little value of its own. It
is thus removed.

BUG=571301
Committed: https://crrev.com/c91b189837297762cdc0ffda3ef97e177f7a1d5f
Cr-Commit-Position: refs/heads/master@{#366388}

[davve, 2015-12-21 10:21:56]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-21 10:21:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1542563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1542563002/1

[davve, 2015-12-21 10:27:50]

davve@opera.com changed reviewers:
+ fs@opera.com, pdr@chromium.org

[davve, 2015-12-21 10:27:51]

After the rewrite, this still tests the sizing and layout parts but throws out a
number of other things.

There are a number of interesting things with this test. For example, a body
width like 445px jumbles the boxes, probably because of a layout issue with
floats. I'll file that separately. I don't think that was related to the
flakiness though.

I don't know the original source of this test, but perhaps I should link back to
that somehow...

[commit-bot: I haz the power, 2015-12-21 11:26:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-21 11:27:00]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fs, 2015-12-21 12:07:01]

On 2015/12/21 at 10:27:51, davve wrote:
> After the rewrite, this still tests the sizing and layout parts but throws out
a number of other things.
> 
> There are a number of interesting things with this test. For example, a body
width like 445px jumbles the boxes, probably because of a layout issue with
floats. I'll file that separately. I don't think that was related to the
flakiness though.
> 
> I don't know the original source of this test, but perhaps I should link back
to that somehow...

I think it might be
http://www.w3.org/2004/CDF/TestSuite/WICD_CDR_WP1/rightsizing-grid/index.xhtml
(at least the #20-3 thing match up...)

Must've been fun picking all those colors =)

LGTM

[davve, 2015-12-21 12:26:56]

On 2015/12/21 12:07:01, fs wrote:
> 
> I think it might be
> http://www.w3.org/2004/CDF/TestSuite/WICD_CDR_WP1/rightsizing-grid/index.xhtml
> (at least the #20-3 thing match up...)

Thanks.

> Must've been fun picking all those colors =)

That was the best thing.

Also, I removed the sizing-flakiness.html test. It depended on one of the
resource files and while trying to fix that I didn't find a reason to keep it.
To my eyes it seems to be a strict subset of rightsizing-grid and one not very
interesting. Please shout if you want the test kept around for some reason.

[fs, 2015-12-21 12:40:29]

On 2015/12/21 at 12:26:56, davve wrote:
> On 2015/12/21 12:07:01, fs wrote:
> > 
> > I think it might be
> >
http://www.w3.org/2004/CDF/TestSuite/WICD_CDR_WP1/rightsizing-grid/index.xhtml
> > (at least the #20-3 thing match up...)
> 
> Thanks.
> 
> > Must've been fun picking all those colors =)
> 
> That was the best thing.
> 
> Also, I removed the sizing-flakiness.html test. It depended on one of the
resource files and while trying to fix that I didn't find a reason to keep it.
To my eyes it seems to be a strict subset of rightsizing-grid and one not very
interesting. Please shout if you want the test kept around for some reason.

For the sake of archeology, maybe mention it in the commit message?

[davve, 2015-12-21 14:46:53]

Description was changed from

==========
Rewrite LayoutTest svg/wicd/rightsizing-grid as a reftest

A number of changes were made to reduce flakyness and make the test
more useful:

 * Rewrite as html reftest.

 * Apply a static body width. The test is no longer depending on the
   viewport width.

 * Use a slim body width. The way the test was written a lot of the
   test actually ended up outside the viewport. Layout tests use
   default size 800x600 and this test expected up to double the height
   compared to the width.

 * Avoid gradients and rounded rectangles since they add nothing to
   what's actually meant to be tested.

BUG=571301
==========

to

==========
Rewrite LayoutTest svg/wicd/rightsizing-grid as a reftest

A number of changes were made to reduce flakyness and make the test
more useful:

 * Rewrite as html reftest.

 * Apply a static body width. The test is no longer depending on the
   viewport width.

 * Use a slim body width. The way the test was written a lot of the
   test actually ended up outside the viewport. Layout tests use
   default size 800x600 and this test expected up to double the height
   compared to the width.

 * Avoid gradients and rounded rectangles since they add nothing to
   what's actually meant to be tested.

The test svg/wicd/sizing-flakiness.html is a subset of the
rightsizing-grid test and should provide little value of its own. It
is thus removed.

BUG=571301
==========

[davve, 2015-12-21 14:47:15]

On 2015/12/21 12:40:29, fs wrote:
> On 2015/12/21 at 12:26:56, davve wrote:
> > Also, I removed the sizing-flakiness.html test. It depended on one of the
> resource files and while trying to fix that I didn't find a reason to keep it.
> To my eyes it seems to be a strict subset of rightsizing-grid and one not very
> interesting. Please shout if you want the test kept around for some reason.
> 
> For the sake of archeology, maybe mention it in the commit message?

done.

[davve, 2015-12-21 14:47:43]

The CQ bit was checked by davve@opera.com

[davve, 2015-12-21 14:47:44]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/1542563002/#ps40001
(title: "Add note about test inspiration")

[commit-bot: I haz the power, 2015-12-21 14:47:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1542563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1542563002/40001

[commit-bot: I haz the power, 2015-12-21 15:37:47]

Description was changed from

==========
Rewrite LayoutTest svg/wicd/rightsizing-grid as a reftest

A number of changes were made to reduce flakyness and make the test
more useful:

 * Rewrite as html reftest.

 * Apply a static body width. The test is no longer depending on the
   viewport width.

 * Use a slim body width. The way the test was written a lot of the
   test actually ended up outside the viewport. Layout tests use
   default size 800x600 and this test expected up to double the height
   compared to the width.

 * Avoid gradients and rounded rectangles since they add nothing to
   what's actually meant to be tested.

The test svg/wicd/sizing-flakiness.html is a subset of the
rightsizing-grid test and should provide little value of its own. It
is thus removed.

BUG=571301
==========

to

==========
Rewrite LayoutTest svg/wicd/rightsizing-grid as a reftest

A number of changes were made to reduce flakyness and make the test
more useful:

 * Rewrite as html reftest.

 * Apply a static body width. The test is no longer depending on the
   viewport width.

 * Use a slim body width. The way the test was written a lot of the
   test actually ended up outside the viewport. Layout tests use
   default size 800x600 and this test expected up to double the height
   compared to the width.

 * Avoid gradients and rounded rectangles since they add nothing to
   what's actually meant to be tested.

The test svg/wicd/sizing-flakiness.html is a subset of the
rightsizing-grid test and should provide little value of its own. It
is thus removed.

BUG=571301
==========

[commit-bot: I haz the power, 2015-12-21 15:37:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-21 15:38:42]

Description was changed from

==========
Rewrite LayoutTest svg/wicd/rightsizing-grid as a reftest

A number of changes were made to reduce flakyness and make the test
more useful:

 * Rewrite as html reftest.

 * Apply a static body width. The test is no longer depending on the
   viewport width.

 * Use a slim body width. The way the test was written a lot of the
   test actually ended up outside the viewport. Layout tests use
   default size 800x600 and this test expected up to double the height
   compared to the width.

 * Avoid gradients and rounded rectangles since they add nothing to
   what's actually meant to be tested.

The test svg/wicd/sizing-flakiness.html is a subset of the
rightsizing-grid test and should provide little value of its own. It
is thus removed.

BUG=571301
==========

to

==========
Rewrite LayoutTest svg/wicd/rightsizing-grid as a reftest

A number of changes were made to reduce flakyness and make the test
more useful:

 * Rewrite as html reftest.

 * Apply a static body width. The test is no longer depending on the
   viewport width.

 * Use a slim body width. The way the test was written a lot of the
   test actually ended up outside the viewport. Layout tests use
   default size 800x600 and this test expected up to double the height
   compared to the width.

 * Avoid gradients and rounded rectangles since they add nothing to
   what's actually meant to be tested.

The test svg/wicd/sizing-flakiness.html is a subset of the
rightsizing-grid test and should provide little value of its own. It
is thus removed.

BUG=571301

Committed: https://crrev.com/c91b189837297762cdc0ffda3ef97e177f7a1d5f
Cr-Commit-Position: refs/heads/master@{#366388}
==========

[commit-bot: I haz the power, 2015-12-21 15:38:43]

Patchset 3 (id:??) landed as
https://crrev.com/c91b189837297762cdc0ffda3ef97e177f7a1d5f
Cr-Commit-Position: refs/heads/master@{#366388}