Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1542553002: Revert of Allow IAT patches to fail when patching for Active Verifier. (Closed)

Created:
5 years ago by Finnur
Modified:
5 years ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow IAT patches to fail when patching for Active Verifier. (patchset #3 id:40001 of https://codereview.chromium.org/1540723002/ ) Reason for revert: Seems to consistently cause Win7 tests to fail. Example log: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/44171/steps/base_unittests/logs/stdio Original issue's description: > Allow IAT patches to fail when patching for Active Verifier. > > Not all loaded modules import CloseHandle and DuplicateHandle so > InstallHandleHooks was failing incorrectly and causing the Handle > Verifier to be disabled. > > Also, continue to patch DuplicateHandle if a module happens to > not import CloseHandle. > > BUG=570912 > > Committed: https://crrev.com/c844be97c13fcf492149a21a0f3d9bf083c3c0d2 > Cr-Commit-Position: refs/heads/master@{#366322} TBR=cpu@chromium.org,wfh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570912 Committed: https://crrev.com/27add94454c6b70921fb0718b5dbbd77eae3c5ec Cr-Commit-Position: refs/heads/master@{#366362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M base/debug/close_handle_hook_win.cc View 2 chunks +14 lines, -10 lines 0 comments Download
M base/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Finnur
Created Revert of Allow IAT patches to fail when patching for Active Verifier.
5 years ago (2015-12-21 10:21:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542553002/1
5 years ago (2015-12-21 10:21:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-21 10:21:42 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-21 10:22:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27add94454c6b70921fb0718b5dbbd77eae3c5ec
Cr-Commit-Position: refs/heads/master@{#366362}

Powered by Google App Engine
This is Rietveld 408576698