Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: gpu/command_buffer/service/common_decoder.h

Issue 1542513002: Switch to standard integer types in gpu/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/common_decoder.h
diff --git a/gpu/command_buffer/service/common_decoder.h b/gpu/command_buffer/service/common_decoder.h
index 53de875625ad33e88d6751514a22c46525cd8102..147b7762c87f89949ef63e40708dd035818ba4d2 100644
--- a/gpu/command_buffer/service/common_decoder.h
+++ b/gpu/command_buffer/service/common_decoder.h
@@ -5,9 +5,13 @@
#ifndef GPU_COMMAND_BUFFER_SERVICE_COMMON_DECODER_H_
#define GPU_COMMAND_BUFFER_SERVICE_COMMON_DECODER_H_
+#include <stddef.h>
+#include <stdint.h>
+
#include <map>
#include <stack>
#include <string>
+#include "base/macros.h"
#include "base/memory/linked_ptr.h"
#include "base/memory/scoped_ptr.h"
#include "gpu/command_buffer/common/buffer.h"
@@ -100,7 +104,7 @@ class GPU_EXPORT CommonDecoder : NON_EXPORTED_BASE(public AsyncAPIInterface) {
}
size_t size_;
- ::scoped_ptr<int8[]> data_;
+ ::scoped_ptr<int8_t[]> data_;
DISALLOW_COPY_AND_ASSIGN(Bucket);
};
@@ -116,10 +120,10 @@ class GPU_EXPORT CommonDecoder : NON_EXPORTED_BASE(public AsyncAPIInterface) {
CommandBufferEngine* engine() const { return engine_; }
// Creates a bucket. If the bucket already exists returns that bucket.
- Bucket* CreateBucket(uint32 bucket_id);
+ Bucket* CreateBucket(uint32_t bucket_id);
// Gets a bucket. Returns NULL if the bucket does not exist.
- Bucket* GetBucket(uint32 bucket_id) const;
+ Bucket* GetBucket(uint32_t bucket_id) const;
// Gets the address of shared memory data, given a shared memory ID and an
// offset. Also checks that the size is consistent with the shared memory
@@ -165,8 +169,8 @@ class GPU_EXPORT CommonDecoder : NON_EXPORTED_BASE(public AsyncAPIInterface) {
private:
// Generate a member function prototype for each command in an automated and
// typesafe way.
- #define COMMON_COMMAND_BUFFER_CMD_OP(name) \
- error::Error Handle##name(uint32 immediate_data_size, const void* data);
+#define COMMON_COMMAND_BUFFER_CMD_OP(name) \
+ error::Error Handle##name(uint32_t immediate_data_size, const void* data);
COMMON_COMMAND_BUFFER_CMDS(COMMON_COMMAND_BUFFER_CMD_OP)
@@ -174,19 +178,18 @@ class GPU_EXPORT CommonDecoder : NON_EXPORTED_BASE(public AsyncAPIInterface) {
CommandBufferEngine* engine_;
- typedef std::map<uint32, linked_ptr<Bucket> > BucketMap;
+ typedef std::map<uint32_t, linked_ptr<Bucket>> BucketMap;
BucketMap buckets_;
- typedef Error (CommonDecoder::*CmdHandler)(
- uint32 immediate_data_size,
- const void* data);
+ typedef Error (CommonDecoder::*CmdHandler)(uint32_t immediate_data_size,
+ const void* data);
// A struct to hold info about each command.
struct CommandInfo {
CmdHandler cmd_handler;
- uint8 arg_flags; // How to handle the arguments for this command
- uint8 cmd_flags; // How to handle this command
- uint16 arg_count; // How many arguments are expected for this command.
+ uint8_t arg_flags; // How to handle the arguments for this command
+ uint8_t cmd_flags; // How to handle this command
+ uint16_t arg_count; // How many arguments are expected for this command.
};
// A table of CommandInfo for all the commands.
« no previous file with comments | « gpu/command_buffer/service/command_buffer_service_unittest.cc ('k') | gpu/command_buffer/service/common_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698