Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_valuebuffer.cc

Issue 1542513002: Switch to standard integer types in gpu/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h" 5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
6 6
7 #include <stdint.h>
8
7 #include "base/command_line.h" 9 #include "base/command_line.h"
8 #include "gpu/command_buffer/common/gles2_cmd_format.h" 10 #include "gpu/command_buffer/common/gles2_cmd_format.h"
9 #include "gpu/command_buffer/common/gles2_cmd_utils.h" 11 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
10 #include "gpu/command_buffer/service/gles2_cmd_decoder_unittest.h" 12 #include "gpu/command_buffer/service/gles2_cmd_decoder_unittest.h"
11 #include "gpu/command_buffer/service/test_helper.h" 13 #include "gpu/command_buffer/service/test_helper.h"
12 #include "gpu/command_buffer/service/valuebuffer_manager.h" 14 #include "gpu/command_buffer/service/valuebuffer_manager.h"
13 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
14 #include "ui/gl/gl_implementation.h" 16 #include "ui/gl/gl_implementation.h"
15 #include "ui/gl/gl_mock.h" 17 #include "ui/gl/gl_mock.h"
16 #include "ui/gl/gl_surface_stub.h" 18 #include "ui/gl/gl_surface_stub.h"
17 19
18 using ::gfx::MockGLInterface; 20 using ::gfx::MockGLInterface;
19 using ::testing::_; 21 using ::testing::_;
20 22
21 namespace gpu { 23 namespace gpu {
22 namespace gles2 { 24 namespace gles2 {
23 25
24 using namespace cmds; 26 using namespace cmds;
25 27
26 TEST_P(GLES2DecoderWithShaderTest, ValuebufferBasic) { 28 TEST_P(GLES2DecoderWithShaderTest, ValuebufferBasic) {
27 const uint32 kBufferId = 123; 29 const uint32_t kBufferId = 123;
28 ValueState valuestate; 30 ValueState valuestate;
29 valuestate.int_value[0] = 111; 31 valuestate.int_value[0] = 111;
30 valuestate.int_value[1] = 222; 32 valuestate.int_value[1] = 222;
31 valuebuffer_manager()->CreateValuebuffer(kBufferId); 33 valuebuffer_manager()->CreateValuebuffer(kBufferId);
32 pending_valuebuffer_state()->UpdateState( 34 pending_valuebuffer_state()->UpdateState(
33 GL_MOUSE_POSITION_CHROMIUM, valuestate); 35 GL_MOUSE_POSITION_CHROMIUM, valuestate);
34 BindValuebufferCHROMIUM cmd1; 36 BindValuebufferCHROMIUM cmd1;
35 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId); 37 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId);
36 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1)); 38 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
37 SubscribeValueCHROMIUM cmd2; 39 SubscribeValueCHROMIUM cmd2;
38 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM); 40 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM);
39 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2)); 41 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2));
40 PopulateSubscribedValuesCHROMIUM cmd3; 42 PopulateSubscribedValuesCHROMIUM cmd3;
41 cmd3.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM); 43 cmd3.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM);
42 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd3)); 44 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd3));
43 EXPECT_CALL(*gl_, Uniform2iv(kUniform2RealLocation, 1, _)).Times(1); 45 EXPECT_CALL(*gl_, Uniform2iv(kUniform2RealLocation, 1, _)).Times(1);
44 UniformValuebufferCHROMIUM cmd4; 46 UniformValuebufferCHROMIUM cmd4;
45 cmd4.Init(kUniform2FakeLocation, GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, 47 cmd4.Init(kUniform2FakeLocation, GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM,
46 GL_MOUSE_POSITION_CHROMIUM); 48 GL_MOUSE_POSITION_CHROMIUM);
47 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd4)); 49 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd4));
48 } 50 }
49 51
50 TEST_P(GLES2DecoderWithShaderTest, SubscribeValuebufferNotBound) { 52 TEST_P(GLES2DecoderWithShaderTest, SubscribeValuebufferNotBound) {
51 const uint32 kBufferId = 123; 53 const uint32_t kBufferId = 123;
52 ValueState valuestate; 54 ValueState valuestate;
53 valuestate.int_value[0] = 111; 55 valuestate.int_value[0] = 111;
54 valuestate.int_value[1] = 222; 56 valuestate.int_value[1] = 222;
55 valuebuffer_manager()->CreateValuebuffer(kBufferId); 57 valuebuffer_manager()->CreateValuebuffer(kBufferId);
56 pending_valuebuffer_state()->UpdateState( 58 pending_valuebuffer_state()->UpdateState(
57 GL_MOUSE_POSITION_CHROMIUM, valuestate); 59 GL_MOUSE_POSITION_CHROMIUM, valuestate);
58 SubscribeValueCHROMIUM cmd1; 60 SubscribeValueCHROMIUM cmd1;
59 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM); 61 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM);
60 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1)); 62 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
61 EXPECT_EQ(GL_INVALID_OPERATION, GetGLError()); 63 EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
62 } 64 }
63 65
64 TEST_P(GLES2DecoderWithShaderTest, PopulateValuebufferNoSubscription) { 66 TEST_P(GLES2DecoderWithShaderTest, PopulateValuebufferNoSubscription) {
65 const uint32 kBufferId = 123; 67 const uint32_t kBufferId = 123;
66 ValueState valuestate; 68 ValueState valuestate;
67 valuestate.int_value[0] = 111; 69 valuestate.int_value[0] = 111;
68 valuestate.int_value[1] = 222; 70 valuestate.int_value[1] = 222;
69 valuebuffer_manager()->CreateValuebuffer(kBufferId); 71 valuebuffer_manager()->CreateValuebuffer(kBufferId);
70 pending_valuebuffer_state()->UpdateState( 72 pending_valuebuffer_state()->UpdateState(
71 GL_MOUSE_POSITION_CHROMIUM, valuestate); 73 GL_MOUSE_POSITION_CHROMIUM, valuestate);
72 BindValuebufferCHROMIUM cmd1; 74 BindValuebufferCHROMIUM cmd1;
73 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId); 75 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId);
74 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1)); 76 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
75 PopulateSubscribedValuesCHROMIUM cmd2; 77 PopulateSubscribedValuesCHROMIUM cmd2;
76 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM); 78 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM);
77 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2)); 79 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2));
78 EXPECT_EQ(GL_NONE, GetGLError()); 80 EXPECT_EQ(GL_NONE, GetGLError());
79 } 81 }
80 82
81 TEST_P(GLES2DecoderWithShaderTest, UniformValuebufferNoState) { 83 TEST_P(GLES2DecoderWithShaderTest, UniformValuebufferNoState) {
82 const uint32 kBufferId = 123; 84 const uint32_t kBufferId = 123;
83 ValueState valuestate; 85 ValueState valuestate;
84 valuestate.int_value[0] = 111; 86 valuestate.int_value[0] = 111;
85 valuestate.int_value[1] = 222; 87 valuestate.int_value[1] = 222;
86 valuebuffer_manager()->CreateValuebuffer(kBufferId); 88 valuebuffer_manager()->CreateValuebuffer(kBufferId);
87 pending_valuebuffer_state()->UpdateState( 89 pending_valuebuffer_state()->UpdateState(
88 GL_MOUSE_POSITION_CHROMIUM, valuestate); 90 GL_MOUSE_POSITION_CHROMIUM, valuestate);
89 BindValuebufferCHROMIUM cmd1; 91 BindValuebufferCHROMIUM cmd1;
90 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId); 92 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId);
91 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1)); 93 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
92 SubscribeValueCHROMIUM cmd2; 94 SubscribeValueCHROMIUM cmd2;
93 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM); 95 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM);
94 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2)); 96 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2));
95 EXPECT_CALL(*gl_, Uniform2iv(kUniform2RealLocation, 1, _)).Times(0); 97 EXPECT_CALL(*gl_, Uniform2iv(kUniform2RealLocation, 1, _)).Times(0);
96 UniformValuebufferCHROMIUM cmd3; 98 UniformValuebufferCHROMIUM cmd3;
97 cmd3.Init(kUniform2FakeLocation, GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, 99 cmd3.Init(kUniform2FakeLocation, GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM,
98 GL_MOUSE_POSITION_CHROMIUM); 100 GL_MOUSE_POSITION_CHROMIUM);
99 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd3)); 101 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd3));
100 EXPECT_EQ(GL_NONE, GetGLError()); 102 EXPECT_EQ(GL_NONE, GetGLError());
101 } 103 }
102 104
103 TEST_P(GLES2DecoderWithShaderTest, UniformValuebufferInvalidLocation) { 105 TEST_P(GLES2DecoderWithShaderTest, UniformValuebufferInvalidLocation) {
104 const uint32 kBufferId = 123; 106 const uint32_t kBufferId = 123;
105 ValueState valuestate; 107 ValueState valuestate;
106 valuestate.int_value[0] = 111; 108 valuestate.int_value[0] = 111;
107 valuestate.int_value[1] = 222; 109 valuestate.int_value[1] = 222;
108 valuebuffer_manager()->CreateValuebuffer(kBufferId); 110 valuebuffer_manager()->CreateValuebuffer(kBufferId);
109 pending_valuebuffer_state()->UpdateState( 111 pending_valuebuffer_state()->UpdateState(
110 GL_MOUSE_POSITION_CHROMIUM, valuestate); 112 GL_MOUSE_POSITION_CHROMIUM, valuestate);
111 BindValuebufferCHROMIUM cmd1; 113 BindValuebufferCHROMIUM cmd1;
112 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId); 114 cmd1.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, kBufferId);
113 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1)); 115 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd1));
114 SubscribeValueCHROMIUM cmd2; 116 SubscribeValueCHROMIUM cmd2;
115 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM); 117 cmd2.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, GL_MOUSE_POSITION_CHROMIUM);
116 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2)); 118 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd2));
117 PopulateSubscribedValuesCHROMIUM cmd3; 119 PopulateSubscribedValuesCHROMIUM cmd3;
118 cmd3.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM); 120 cmd3.Init(GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM);
119 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd3)); 121 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd3));
120 EXPECT_CALL(*gl_, Uniform2iv(kUniform2RealLocation, 1, _)).Times(0); 122 EXPECT_CALL(*gl_, Uniform2iv(kUniform2RealLocation, 1, _)).Times(0);
121 UniformValuebufferCHROMIUM cmd4; 123 UniformValuebufferCHROMIUM cmd4;
122 cmd4.Init(kUniform1FakeLocation, GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM, 124 cmd4.Init(kUniform1FakeLocation, GL_SUBSCRIBED_VALUES_BUFFER_CHROMIUM,
123 GL_MOUSE_POSITION_CHROMIUM); 125 GL_MOUSE_POSITION_CHROMIUM);
124 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd4)); 126 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd4));
125 EXPECT_EQ(GL_INVALID_OPERATION, GetGLError()); 127 EXPECT_EQ(GL_INVALID_OPERATION, GetGLError());
126 } 128 }
127 129
128 } // namespace gles2 130 } // namespace gles2
129 } // namespace gpu 131 } // namespace gpu
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc ('k') | gpu/command_buffer/service/gles2_cmd_validation.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698