Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 15425005: Don't force layout for mouse event hit tests (Closed)

Created:
7 years, 7 months ago by cbiesinger
Modified:
7 years, 7 months ago
Reviewers:
eseidel, ojan
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

Don't force layout for mouse event hit tests Second try. This time with a different approach to deal with tests. See the EventSender change (this kinda reverts r150324). Before the initial document layout, we shouldn't force a layout for mouse events, because they are not intended for the new document anyway - the user can't see the document yet! Just ignore those events by making the hit tests match nothing. Otherwise, the hit test would force a layout, which is undesirable because that leads to a flash of an empty document. BUG=1373 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150837

Patch Set 1 #

Total comments: 1

Patch Set 2 : have to force layout for gesture events #

Patch Set 3 : touch adjustment in window.internals also needs layout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -6 lines) Patch
A LayoutTests/fast/repaint/event-while-loading.html View 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/event-while-loading-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 5 chunks +10 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp View 1 13 chunks +37 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cbiesinger
7 years, 7 months ago (2013-05-21 02:05:31 UTC) #1
ojan
lgtm https://codereview.chromium.org/15425005/diff/1/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp File Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp (right): https://codereview.chromium.org/15425005/diff/1/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp#newcode431 Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:431: webview()->layout(); Nit: Could move this into a helper ...
7 years, 7 months ago (2013-05-21 02:12:37 UTC) #2
cbiesinger
On 2013/05/21 02:12:37, ojan wrote: > lgtm > > https://codereview.chromium.org/15425005/diff/1/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp > File Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp (right): > ...
7 years, 7 months ago (2013-05-21 02:19:58 UTC) #3
cbiesinger
7 years, 7 months ago (2013-05-21 22:38:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r150837 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698