Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 154243005: Better tests for the Parser / Preparser unification. (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 10 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Better tests for the Parser / Preparser unification. We need a way to assert that for a given source code snippet, an error *is* produced or *is not* produced. Otherwise we might accidentally create new errors or start accepting code which was previously not accepted. Just checking that Parser and PreParser produce the same result doesn't cut it. BUG=3126 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19107

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review (ulan@) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -183 lines) Patch
M test/cctest/test-parsing.cc View 1 12 chunks +290 lines, -183 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
lgtm https://codereview.chromium.org/154243005/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/154243005/diff/1/test/cctest/test-parsing.cc#newcode1116 test/cctest/test-parsing.cc:1116: bool assert_success, Maybe enum is better than two ...
6 years, 10 months ago (2014-02-05 15:00:10 UTC) #1
marja
https://codereview.chromium.org/154243005/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/154243005/diff/1/test/cctest/test-parsing.cc#newcode1116 test/cctest/test-parsing.cc:1116: bool assert_success, On 2014/02/05 15:00:10, ulan wrote: > Maybe ...
6 years, 10 months ago (2014-02-05 15:28:12 UTC) #2
marja
Committed patchset #2 manually as r19107 (presubmit successful).
6 years, 10 months ago (2014-02-05 15:30:09 UTC) #3
ulan
6 years, 10 months ago (2014-02-05 15:30:34 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698