Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1542373002: Fix a bad virtual keyword removal from commit 0f6b51c. (Closed)

Created:
4 years, 12 months ago by Lei Zhang
Modified:
4 years, 12 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a bad virtual keyword removal from commit 0f6b51c. BUG=546744 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ae58ed8bccc56dd78c12d89972b19d58de94f790

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -73 lines) Patch
M fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h View 1 1 chunk +7 lines, -15 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_FontMap.h View 1 2 chunks +8 lines, -6 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp View 1 5 chunks +4 lines, -15 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ListBox.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 9 chunks +15 lines, -20 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_FontMap.cpp View 1 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
4 years, 12 months ago (2015-12-24 18:52:06 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1542373002/diff/1/fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h File fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h (right): https://codereview.chromium.org/1542373002/diff/1/fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h#newcode24 fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h:24: void Initialize(); Distinct from CPWL_FontMap::Init() virtual? Confusing. https://codereview.chromium.org/1542373002/diff/1/fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h#newcode45 ...
4 years, 12 months ago (2015-12-25 01:11:57 UTC) #3
Lei Zhang
https://codereview.chromium.org/1542373002/diff/1/fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h File fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h (right): https://codereview.chromium.org/1542373002/diff/1/fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h#newcode24 fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h:24: void Initialize(); On 2015/12/25 01:11:56, Tom Sepez (ooo) wrote: ...
4 years, 12 months ago (2015-12-25 04:42:47 UTC) #4
Lei Zhang
4 years, 12 months ago (2015-12-25 05:01:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ae58ed8bccc56dd78c12d89972b19d58de94f790 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698