Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1542323002: Switch to standard integer types in base/i18n/. (Closed)

Created:
4 years, 12 months ago by Avi (use Gerrit)
Modified:
4 years, 12 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, jshin+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in base/i18n/. BUG=138542 TBR=jshin@chromium.org Committed: https://crrev.com/e3c627097cf69e4ff73e89be52c22c080eb37f4d Cr-Commit-Position: refs/heads/master@{#366811}

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -92 lines) Patch
M base/i18n/bidi_line_iterator.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/break_iterator.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M base/i18n/break_iterator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/break_iterator_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/i18n/build_utf8_validator_tables.cc View 1 15 chunks +43 lines, -39 lines 0 comments Download
M base/i18n/case_conversion.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/char_iterator.h View 1 5 chunks +21 lines, -17 lines 0 comments Download
M base/i18n/file_util_icu.cc View 2 chunks +4 lines, -1 line 0 comments Download
M base/i18n/file_util_icu_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M base/i18n/icu_encoding_detection.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/icu_string_conversions.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M base/i18n/icu_string_conversions_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M base/i18n/icu_util.h View 3 chunks +4 lines, -2 lines 0 comments Download
M base/i18n/icu_util.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M base/i18n/message_formatter.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/i18n/number_formatting.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M base/i18n/number_formatting.cc View 2 chunks +3 lines, -1 line 0 comments Download
M base/i18n/number_formatting_unittest.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M base/i18n/rtl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/i18n/rtl_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M base/i18n/streaming_utf8_validator.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M base/i18n/streaming_utf8_validator.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/i18n/streaming_utf8_validator_perftest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M base/i18n/streaming_utf8_validator_unittest.cc View 1 7 chunks +11 lines, -9 lines 0 comments Download
M base/i18n/string_search.h View 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/string_search.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/string_search_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/time_formatting.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/timezone.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M base/i18n/utf8_validator_tables.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M base/i18n/utf8_validator_tables.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542323002/1
4 years, 12 months ago (2015-12-24 04:18:28 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/152833)
4 years, 12 months ago (2015-12-24 04:28:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542323002/20001
4 years, 12 months ago (2015-12-24 04:48:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/46779)
4 years, 12 months ago (2015-12-24 04:54:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542323002/40001
4 years, 12 months ago (2015-12-24 05:33:25 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 12 months ago (2015-12-24 06:52:43 UTC) #11
commit-bot: I haz the power
4 years, 12 months ago (2015-12-24 06:53:26 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e3c627097cf69e4ff73e89be52c22c080eb37f4d
Cr-Commit-Position: refs/heads/master@{#366811}

Powered by Google App Engine
This is Rietveld 408576698