Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1542253002: [Test] Mark flaky test cctest/test-lockers/LockAndUnlockDifferentIsolates (Closed)

Created:
4 years, 12 months ago by Michael Hablich
Modified:
4 years, 12 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Test] Mark flaky test cctest/test-lockers/LockAndUnlockDifferentIsolates BUG=v8:4642 LOG=N NOTRY=true R=machenbach@chromium.org,mvstanton@chromium.org Committed: https://crrev.com/2cea136a877bd88838ce0fbd1df500840b509be1 Cr-Commit-Position: refs/heads/master@{#33021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Michael Hablich
PTAL
4 years, 12 months ago (2015-12-23 09:45:01 UTC) #1
mvstanton
lgtm
4 years, 12 months ago (2015-12-23 09:45:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542253002/1
4 years, 12 months ago (2015-12-23 09:49:30 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9240)
4 years, 12 months ago (2015-12-23 09:51:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542253002/1
4 years, 12 months ago (2015-12-23 10:01:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-23 10:03:13 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2cea136a877bd88838ce0fbd1df500840b509be1 Cr-Commit-Position: refs/heads/master@{#33021}
4 years, 12 months ago (2015-12-23 10:03:27 UTC) #13
Michael Achenbach
The FLAKY feature is not supported anymore on the buildbot side. Please mark as SKIP. ...
4 years, 12 months ago (2015-12-23 12:18:37 UTC) #14
Michael Achenbach
4 years, 12 months ago (2015-12-23 12:19:00 UTC) #15
Message was sent while issue was closed.
On 2015/12/23 12:18:37, Michael Achenbach (OOO) wrote:
> The FLAKY feature is not supported anymore on the buildbot side. Please mark
as
> SKIP. Or in this case, as it seems to be a turbo-only probole, as PASS,
> NOVARIANTS.

s/probole/problem

Powered by Google App Engine
This is Rietveld 408576698