Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: chrome/browser/resources/PRESUBMIT.py

Issue 154223003: Exclude vulcanize-generated HTML/JS from PRESUBMIT.py checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « PRESUBMIT.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/PRESUBMIT.py
diff --git a/chrome/browser/resources/PRESUBMIT.py b/chrome/browser/resources/PRESUBMIT.py
index 0aa0d6350df9b7b7482078d93211f0dd69a8a0ed..16b169a37bd3ef488aaa6903ab4326eb70074eca 100644
--- a/chrome/browser/resources/PRESUBMIT.py
+++ b/chrome/browser/resources/PRESUBMIT.py
@@ -47,8 +47,11 @@ def _CommonChecks(input_api, output_api):
def _html_css_js_resource(p):
return p.endswith(('.html', '.css', '.js')) and p.startswith(resources)
+ WHITELIST = ['chrome/browser/resources/pdf/index.html',
+ 'chrome/browser/resources/pdf/index.js']
def is_resource(maybe_resource):
- return _html_css_js_resource(maybe_resource.AbsoluteLocalPath())
+ return (not(maybe_resource.LocalPath() in WHITELIST) and
M-A Ruel 2014/02/15 01:46:57 then it is a blacklist. Rename the variable, and u
raymes 2014/02/16 23:14:31 Done.
+ _html_css_js_resource(maybe_resource.AbsoluteLocalPath()))
results.extend(css_checker.CSSChecker(
input_api, output_api, file_filter=is_resource).RunChecks())
« no previous file with comments | « PRESUBMIT.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698