Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Side by Side Diff: PRESUBMIT.py

Issue 154223003: Exclude vulcanize-generated HTML/JS from PRESUBMIT.py checks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
11 11
12 import re 12 import re
13 import subprocess 13 import subprocess
14 import sys 14 import sys
15 15
16 16
17 _EXCLUDED_PATHS = ( 17 _EXCLUDED_PATHS = (
18 r"^breakpad[\\\/].*", 18 r"^breakpad[\\\/].*",
19 r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_rules.py", 19 r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_rules.py",
20 r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_simple.py", 20 r"^native_client_sdk[\\\/]src[\\\/]build_tools[\\\/]make_simple.py",
21 r"^native_client_sdk[\\\/]src[\\\/]tools[\\\/].*.mk", 21 r"^native_client_sdk[\\\/]src[\\\/]tools[\\\/].*.mk",
22 r"^net[\\\/]tools[\\\/]spdyshark[\\\/].*", 22 r"^net[\\\/]tools[\\\/]spdyshark[\\\/].*",
23 r"^skia[\\\/].*", 23 r"^skia[\\\/].*",
24 r"^v8[\\\/].*", 24 r"^v8[\\\/].*",
25 r".*MakeFile$", 25 r".*MakeFile$",
26 r".+_autogen\.h$", 26 r".+_autogen\.h$",
27 r".+[\\\/]pnacl_shim\.c$", 27 r".+[\\\/]pnacl_shim\.c$",
28 r"^gpu[\\\/]config[\\\/].*_list_json\.cc$", 28 r"^gpu[\\\/]config[\\\/].*_list_json\.cc$",
29 r"^chrome[\\\/]browser[\\\/]resources[\\\/]pdf[\\\/]index.js"
29 ) 30 )
30 31
31 # TestRunner library is temporarily excluded from pan-project checks until 32 # TestRunner library is temporarily excluded from pan-project checks until
32 # it's transitioned to chromium coding style. 33 # it's transitioned to chromium coding style.
33 _TESTRUNNER_PATHS = ( 34 _TESTRUNNER_PATHS = (
34 r"^content[\\\/]shell[\\\/]renderer[\\\/]test_runner[\\\/].*", 35 r"^content[\\\/]shell[\\\/]renderer[\\\/]test_runner[\\\/].*",
35 r"^content[\\\/]shell[\\\/]common[\\\/]test_runner[\\\/].*", 36 r"^content[\\\/]shell[\\\/]common[\\\/]test_runner[\\\/].*",
36 ) 37 )
37 38
38 # Fragment of a regular expression that matches C++ and Objective-C++ 39 # Fragment of a regular expression that matches C++ and Objective-C++
(...skipping 1418 matching lines...) Expand 10 before | Expand all | Expand 10 after
1457 trybots.extend(GetDefaultTryConfigs(['cros_x86'])) 1458 trybots.extend(GetDefaultTryConfigs(['cros_x86']))
1458 1459
1459 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1460 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1460 # unless they're .gyp(i) files as changes to those files can break the gyp 1461 # unless they're .gyp(i) files as changes to those files can break the gyp
1461 # step on that bot. 1462 # step on that bot.
1462 if (not all(re.search('^chrome', f) for f in files) or 1463 if (not all(re.search('^chrome', f) for f in files) or
1463 any(re.search('\.gypi?$', f) for f in files)): 1464 any(re.search('\.gypi?$', f) for f in files)):
1464 trybots.extend(GetDefaultTryConfigs(['android_aosp'])) 1465 trybots.extend(GetDefaultTryConfigs(['android_aosp']))
1465 1466
1466 return trybots 1467 return trybots
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/PRESUBMIT.py » ('j') | chrome/browser/resources/PRESUBMIT.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698