Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1542213003: GN: Add assert(is_chromeos) to //chrome/browser/chromeos (Closed)

Created:
5 years ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Add assert(is_chromeos) to //chrome/browser/chromeos This helps to ensure that targets not supported on a platform are not included in the "all" target. BUG=None Committed: https://crrev.com/dac52d56619f9586c387a723f4f6578467f39a88 Cr-Commit-Position: refs/heads/master@{#367473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
agrieve
5 years ago (2015-12-23 19:56:34 UTC) #2
oshima
lgtm
4 years, 11 months ago (2016-01-04 21:44:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542213003/1
4 years, 11 months ago (2016-01-05 02:51:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 03:35:24 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 03:36:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dac52d56619f9586c387a723f4f6578467f39a88
Cr-Commit-Position: refs/heads/master@{#367473}

Powered by Google App Engine
This is Rietveld 408576698