Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1542143003: Fix a few -Wignored-qualifiers warnings. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
4 years, 11 months ago
CC:
Camillo Bruni, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix a few -Wignored-qualifiers warnings. Committed: https://crrev.com/beef98f160530074ceb7e734bac55058ceb188b8 Cr-Commit-Position: refs/heads/master@{#33122}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/code-generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/frame.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
Lei Zhang
Building PDFium + V8 with Clang on Linux, I get many warnings: 'const' type qualifier ...
5 years ago (2015-12-23 00:32:13 UTC) #2
Camillo Bruni
LGTM though not enough V8-foo to allow commits :P
5 years ago (2015-12-23 16:17:41 UTC) #4
Lei Zhang
I'm just going to hit the CQ button and see what happens. :)
4 years, 11 months ago (2015-12-29 22:38:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542143003/1
4 years, 11 months ago (2015-12-29 22:38:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9330)
4 years, 11 months ago (2015-12-29 22:46:05 UTC) #9
Lei Zhang
https://codereview.chromium.org/1559923002/ landed, so now we have patch set 2.
4 years, 11 months ago (2016-01-04 19:02:03 UTC) #10
Benedikt Meurer
LGTM (rubber-stamped)
4 years, 11 months ago (2016-01-05 10:20:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1542143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1542143003/20001
4 years, 11 months ago (2016-01-05 17:02:07 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-05 17:23:37 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 17:23:59 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/beef98f160530074ceb7e734bac55058ceb188b8
Cr-Commit-Position: refs/heads/master@{#33122}

Powered by Google App Engine
This is Rietveld 408576698