Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 1542113002: Do not mark from native code. Check color and call incremental marker instead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/incremental-marking.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/bootstrapper.h" 8 #include "src/bootstrapper.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 4058 matching lines...) Expand 10 before | Expand all | Expand 10 after
4069 Label::kNear); 4069 Label::kNear);
4070 4070
4071 __ jmp(&need_incremental); 4071 __ jmp(&need_incremental);
4072 4072
4073 __ bind(&ensure_not_white); 4073 __ bind(&ensure_not_white);
4074 } 4074 }
4075 4075
4076 // We need an extra register for this, so we push the object register 4076 // We need an extra register for this, so we push the object register
4077 // temporarily. 4077 // temporarily.
4078 __ push(regs_.object()); 4078 __ push(regs_.object());
4079 __ EnsureNotWhite(regs_.scratch0(), // The value. 4079 __ JumpIfWhite(regs_.scratch0(), // The value.
4080 regs_.scratch1(), // Scratch. 4080 regs_.scratch1(), // Scratch.
4081 regs_.object(), // Scratch. 4081 regs_.object(), // Scratch.
4082 &need_incremental_pop_object, 4082 &need_incremental_pop_object, Label::kNear);
4083 Label::kNear);
4084 __ pop(regs_.object()); 4083 __ pop(regs_.object());
4085 4084
4086 regs_.Restore(masm); 4085 regs_.Restore(masm);
4087 if (on_no_need == kUpdateRememberedSetOnNoNeedToInformIncrementalMarker) { 4086 if (on_no_need == kUpdateRememberedSetOnNoNeedToInformIncrementalMarker) {
4088 __ RememberedSetHelper(object(), address(), value(), save_fp_regs_mode(), 4087 __ RememberedSetHelper(object(), address(), value(), save_fp_regs_mode(),
4089 MacroAssembler::kReturnAtEnd); 4088 MacroAssembler::kReturnAtEnd);
4090 } else { 4089 } else {
4091 __ ret(0); 4090 __ ret(0);
4092 } 4091 }
4093 4092
(...skipping 1558 matching lines...) Expand 10 before | Expand all | Expand 10 after
5652 Operand(ebp, 7 * kPointerSize), NULL); 5651 Operand(ebp, 7 * kPointerSize), NULL);
5653 } 5652 }
5654 5653
5655 5654
5656 #undef __ 5655 #undef __
5657 5656
5658 } // namespace internal 5657 } // namespace internal
5659 } // namespace v8 5658 } // namespace v8
5660 5659
5661 #endif // V8_TARGET_ARCH_IA32 5660 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/heap/incremental-marking.cc ('k') | src/ia32/macro-assembler-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698