Do not mark from native code. Check color and call incremental marker instead.

Do not mark from native code. Check color and call incremental marker instead.

BUG=chromium:561449
LOG=n

Committed: https://crrev.com/866f9e6e87a4e10041b94846e86c439a0af592f7
Cr-Commit-Position: refs/heads/master@{#33026}

[payer, 2015-12-23 10:51:28]

hpayer@google.com changed reviewers:
+ hpayer@google.com, ulan@chromium.org

[payer, 2015-12-23 10:51:45]

Description was changed from

==========
Remove inlined marking part.

BUG=
==========

to

==========
Remove inlined marking part.

BUG=chromium:561449
LOG=n
==========

[ulan, 2015-12-23 11:02:20]

lgtm

https://codereview.chromium.org/1542113002/diff/120001/src/arm/macro-assemble...
File src/arm/macro-assembler-arm.h (right):

https://codereview.chromium.org/1542113002/diff/120001/src/arm/macro-assemble...
src/arm/macro-assembler-arm.h:247: void CheckIfWhite(Register object, Register
scratch1, Register scratch2,
Let's call it JumpIfWhite to be more descriptive.

https://codereview.chromium.org/1542113002/diff/120001/src/arm/macro-assemble...
src/arm/macro-assembler-arm.h:248: Register scratch3, Label* object_is_white);
should be value_is_white for consistency with .cc

https://codereview.chromium.org/1542113002/diff/120001/src/arm64/macro-assemb...
File src/arm64/macro-assembler-arm64.h (right):

https://codereview.chromium.org/1542113002/diff/120001/src/arm64/macro-assemb...
src/arm64/macro-assembler-arm64.h:1806: Label* object_is_white);
should be value_is_white for consistency with .cc

https://codereview.chromium.org/1542113002/diff/120001/src/ppc/macro-assemble...
File src/ppc/macro-assembler-ppc.cc (right):

https://codereview.chromium.org/1542113002/diff/120001/src/ppc/macro-assemble...
src/ppc/macro-assembler-ppc.cc:3238: bne(value_is_white, cr0);
be

[Hannes Payer (out of office), 2015-12-23 12:14:05]

https://codereview.chromium.org/1542113002/diff/120001/src/arm/macro-assemble...
File src/arm/macro-assembler-arm.h (right):

https://codereview.chromium.org/1542113002/diff/120001/src/arm/macro-assemble...
src/arm/macro-assembler-arm.h:247: void CheckIfWhite(Register object, Register
scratch1, Register scratch2,
On 2015/12/23 11:02:20, ulan wrote:
> Let's call it JumpIfWhite to be more descriptive.

Done.

https://codereview.chromium.org/1542113002/diff/120001/src/arm/macro-assemble...
src/arm/macro-assembler-arm.h:248: Register scratch3, Label* object_is_white);
On 2015/12/23 11:02:20, ulan wrote:
> should be value_is_white for consistency with .cc

Done.

https://codereview.chromium.org/1542113002/diff/120001/src/arm64/macro-assemb...
File src/arm64/macro-assembler-arm64.h (right):

https://codereview.chromium.org/1542113002/diff/120001/src/arm64/macro-assemb...
src/arm64/macro-assembler-arm64.h:1806: Label* object_is_white);
On 2015/12/23 11:02:20, ulan wrote:
> should be value_is_white for consistency with .cc

Done.

https://codereview.chromium.org/1542113002/diff/120001/src/ppc/macro-assemble...
File src/ppc/macro-assembler-ppc.cc (right):

https://codereview.chromium.org/1542113002/diff/120001/src/ppc/macro-assemble...
src/ppc/macro-assembler-ppc.cc:3238: bne(value_is_white, cr0);
On 2015/12/23 11:02:20, ulan wrote:
> be

beq. Done.

[Hannes Payer (out of office), 2015-12-23 12:14:14]

hpayer@chromium.org changed reviewers:
- hpayer@google.com

[Hannes Payer (out of office), 2015-12-23 12:14:21]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-12-23 12:14:21]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/1542113002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-12-23 12:14:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1542113002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1542113002/140001

[commit-bot: I haz the power, 2015-12-23 12:52:05]

Description was changed from

==========
Remove inlined marking part.

BUG=chromium:561449
LOG=n
==========

to

==========
Remove inlined marking part.

BUG=chromium:561449
LOG=n
==========

[commit-bot: I haz the power, 2015-12-23 12:52:06]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-12-23 12:52:42]

Description was changed from

==========
Remove inlined marking part.

BUG=chromium:561449
LOG=n
==========

to

==========
Remove inlined marking part.

BUG=chromium:561449
LOG=n

Committed: https://crrev.com/866f9e6e87a4e10041b94846e86c439a0af592f7
Cr-Commit-Position: refs/heads/master@{#33026}
==========

[commit-bot: I haz the power, 2015-12-23 12:52:42]

Patchset 8 (id:??) landed as
https://crrev.com/866f9e6e87a4e10041b94846e86c439a0af592f7
Cr-Commit-Position: refs/heads/master@{#33026}

[Hannes Payer (out of office), 2015-12-23 13:09:44]

Description was changed from

==========
Remove inlined marking part.

BUG=chromium:561449
LOG=n

Committed: https://crrev.com/866f9e6e87a4e10041b94846e86c439a0af592f7
Cr-Commit-Position: refs/heads/master@{#33026}
==========

to

==========
Do not mark from native code. Check color and call incremental marker instead.

BUG=chromium:561449
LOG=n

Committed: https://crrev.com/866f9e6e87a4e10041b94846e86c439a0af592f7
Cr-Commit-Position: refs/heads/master@{#33026}
==========