Use OAuth2 token for sync

sync/internal_api/sync_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/internal_api/sync_manager_impl.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/bind.h"
@@ skipping 579 matching lines @@
            << ModelTypeSetToString(disabled_types);
   return directory()->PurgeEntriesWithTypeIn(disabled_types, failed_types);
 }
 
 void SyncManagerImpl::UpdateCredentials(const SyncCredentials& credentials) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(initialized_);
   DCHECK(!credentials.email.empty());
   DCHECK(!credentials.sync_token.empty());
 
-  observing_network_connectivity_changes_ = true;
   if (!connection_manager_->set_auth_token(credentials.sync_token))
     return;  // Auth token is known to be invalid, so exit early.
 
+  if (connection_manager_->server_status() == HttpResponse::SYNC_AUTH_ERROR)
+    connection_manager_->SetServerStatus(HttpResponse::TOKEN_REFRESHED);
+

[Andrew T Wilson (Slow), 2013/05/24 14:10:15]

Hmm. I'm not sure why it's safe to move
"observing_network_connectivity_changes_=true" down here after the early exit
above.

I'm also not sure why we need this TOKEN_REFRESHED state - from the standpoint
of the SyncManager why didn't the old implementation work?

[pavely, 2013/05/30 07:42:12]

if(set_auth_token) condition means "New credentials are still no good for
talking to server. I won't even try". Presumably connecting to server when
connection is restored will not succeed, thus moving
observing_network_connectivity_changes_=true.

TOKEN_REFRESHED was used in more places in earlier version of this change. I
didn't realize i don't need it anymore.

I'll revert both changes.

+  observing_network_connectivity_changes_ = true;
+
   invalidator_->UpdateCredentials(credentials.email, credentials.sync_token);
   scheduler_->OnCredentialsUpdated();
 }
 
 void SyncManagerImpl::UpdateEnabledTypes(ModelTypeSet enabled_types) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(initialized_);
   invalidator_->UpdateRegisteredIds(
       this,
       ModelTypeSetToObjectIdSet(enabled_types));
@@ skipping 780 matching lines @@
 int SyncManagerImpl::GetDefaultNudgeDelay() {
   return kDefaultNudgeDelayMilliseconds;
 }
 
 // static.
 int SyncManagerImpl::GetPreferencesNudgeDelay() {
   return kPreferencesNudgeDelayMilliseconds;
 }
 
 }  // namespace syncer