Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4410)

Unified Diff: chrome/browser/ui/views/simple_message_box_views.cc

Issue 154203002: Remove unnecessary uses of aura::Env::GetDispatcher (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | ui/aura/env.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/simple_message_box_views.cc
diff --git a/chrome/browser/ui/views/simple_message_box_views.cc b/chrome/browser/ui/views/simple_message_box_views.cc
index fb85878846331398889c9e631f79949aa6303339..f41a1ee587f82f8e6e631dca3c2fe9336f4a361b 100644
--- a/chrome/browser/ui/views/simple_message_box_views.cc
+++ b/chrome/browser/ui/views/simple_message_box_views.cc
@@ -13,20 +13,18 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/ui/views/constrained_window_views.h"
#include "grit/generated_resources.h"
+#include "ui/aura/client/dispatcher_client.h"
+#include "ui/aura/env.h"
+#include "ui/aura/root_window.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/views/controls/message_box_view.h"
#include "ui/views/widget/widget.h"
#include "ui/views/window/dialog_delegate.h"
-#if defined(USE_AURA)
-#include "ui/aura/client/dispatcher_client.h"
-#include "ui/aura/env.h"
-#include "ui/aura/root_window.h"
#if defined(OS_WIN)
#include "chrome/browser/ui/views/simple_message_box_win.h"
#endif
-#endif
namespace chrome {
@@ -175,12 +173,7 @@ const views::Widget* SimpleMessageBoxViews::GetWidget() const {
}
bool SimpleMessageBoxViews::Dispatch(const base::NativeEvent& event) {
-#if defined(OS_WIN)
- TranslateMessage(&event);
- DispatchMessage(&event);
-#elif defined(USE_AURA)
aura::Env::GetInstance()->GetDispatcher()->Dispatch(event);
-#endif
return should_show_dialog_;
}
@@ -208,7 +201,6 @@ MessageBoxResult ShowMessageBoxImpl(gfx::NativeWindow parent,
new SimpleMessageBoxViews(title, message, type, yes_text, no_text));
CreateBrowserModalDialogViews(dialog.get(), parent)->Show();
-#if defined(USE_AURA)
aura::Window* anchor = parent;
aura::client::DispatcherClient* client = anchor ?
aura::client::GetDispatcherClient(anchor->GetRootWindow()) : NULL;
@@ -220,14 +212,6 @@ MessageBoxResult ShowMessageBoxImpl(gfx::NativeWindow parent,
client = aura::client::GetDispatcherClient(anchor->GetRootWindow());
}
client->RunWithDispatcher(dialog.get(), anchor, true);
-#else
- {
- base::MessageLoop::ScopedNestableTaskAllower allow(
- base::MessageLoopForUI::current());
- base::RunLoop run_loop(dialog);
- run_loop.Run();
- }
-#endif
return dialog->result();
}
@@ -241,7 +225,6 @@ MessageBoxResult ShowMessageBox(gfx::NativeWindow parent,
parent, title, message, type, base::string16(), base::string16());
}
-#if defined(USE_AURA)
MessageBoxResult ShowMessageBoxWithButtonText(gfx::NativeWindow parent,
const base::string16& title,
const base::string16& message,
@@ -250,6 +233,5 @@ MessageBoxResult ShowMessageBoxWithButtonText(gfx::NativeWindow parent,
return ShowMessageBoxImpl(
parent, title, message, MESSAGE_BOX_TYPE_QUESTION, yes_text, no_text);
}
-#endif
} // namespace chrome
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | ui/aura/env.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698