Issue 154203002: Remove unnecessary uses of aura::Env::GetDispatcher

Issue 154203002: Remove unnecessary uses of aura::Env::GetDispatcher (Closed)

Created:
6 years, 10 months ago by sadrul

Modified:
6 years, 10 months ago

Reviewers:
darin (slow to review), sky

CC:
chromium-reviews, alicet1, ben+aura_chromium.org, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, msw+watch_chromium.org, kalyank, ben+views_chromium.org, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove unnecessary uses of aura::Env::GetDispatcher Avoid using aura::Env::GetDispatcher() as the dispatcher for new instances of base::RunLoop()s, since for both Windows and X11, it's the same as the message-pump. This patch also removes some non-aura views code, and some unnecessary USE_AURA ifdefs. R=darin@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249105

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : . #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -96 lines)			Patch
M	ash/drag_drop/drag_drop_controller.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/test/ash_test_helper.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/toplevel_window_event_handler.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	base/message_loop/message_loop.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	base/run_loop.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/simple_message_box_views.cc	View	1 2 3 4	6 chunks	+3 lines, -21 lines	0 comments	Download
M	ui/aura/env.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/aura/gestures/gesture_recognizer_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/aura/root_window_unittest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/aura/test/aura_test_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/x/selection_requestor.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/font_smoothing_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/bubble/bubble_delegate_unittest.cc	View		5 chunks	+1 line, -11 lines	0 comments	Download
M	ui/views/controls/menu/menu_controller.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/views/controls/menu/menu_controller.cc	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	ui/views/focus/accelerator_handler.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	ui/views/focus/accelerator_handler_aura.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	ui/views/test/views_test_base.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ui/views/test/views_test_base.cc	View		3 chunks	+0 lines, -16 lines	0 comments	Download
M	ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/widget_interactive_uitest.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

sky

Do we even need Env::GetDispatcher? https://codereview.chromium.org/154203002/diff/220001/chrome/browser/ui/views/simple_message_box_views.cc File chrome/browser/ui/views/simple_message_box_views.cc (right): https://codereview.chromium.org/154203002/diff/220001/chrome/browser/ui/views/simple_message_box_views.cc#newcode176 chrome/browser/ui/views/simple_message_box_views.cc:176: #if defined(OS_WIN) Can you ...

6 years, 10 months ago (2014-02-05 14:22:26 UTC) #2

sadrul

> Do we even need Env::GetDispatcher? We still need them in a few places, where ...

6 years, 10 months ago (2014-02-05 14:53:06 UTC) #3

sadrul

6 years, 10 months ago (2014-02-05 20:58:28 UTC) #7

Message was sent while issue was closed.

Committed patchset #5 manually as r249105 (presubmit successful).

Expand Messages | Collapse Messages