content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc - Issue 1542013005: Add a new driver bug workaround SANDBOX_START_EARLY

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc

Issue 1542013005: Add a new driver bug workaround SANDBOX_START_EARLY Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add some draft code to discuss about generalizing EarlySandbox for gpu process Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc

diff --git a/content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc b/content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc

index 7a3620ccf667abf92be59f6caf8b3bcf4369f1f7..92a5409760eb02d46237d002f0cc75f6c2a1bbf5 100644

--- a/content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc

+++ b/content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc

@@ -170,6 +170,9 @@ std::unique_ptr<SandboxBPFBasePolicy> GetGpuProcessSandbox() {

allow_sysv_shm = true;

}

+ // XXX: Generalize CrosArmGpuProcessPolicy to a new

+ // GpuProcessPolicyEarlySandbox then here just rely on if

+ // has switches::kGpuSandboxStartEarly

if (IsChromeOS() && IsArchitectureArm()) {

return std::unique_ptr<SandboxBPFBasePolicy>(

new CrosArmGpuProcessPolicy(allow_sysv_shm));