Add a new driver bug workaround SANDBOX_START_EARLY

content/gpu/gpu_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdlib.h>
 
 #include <memory>
 #include <utility>
 
 #include "base/lazy_instance.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/statistics_recorder.h"
 #include "base/rand_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
+#include "base/sys_info.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
 #include "base/threading/platform_thread.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
 #include "content/child/child_process.h"
 #include "content/common/content_constants_internal.h"
 #include "content/common/gpu_host_messages.h"
 #include "content/common/sandbox_linux/sandbox_linux.h"
 #include "content/gpu/gpu_child_thread.h"
 #include "content/gpu/gpu_process.h"
 #include "content/gpu/gpu_watchdog_thread.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/main_function_params.h"
 #include "gpu/command_buffer/service/gpu_switches.h"
 #include "gpu/config/gpu_info_collector.h"
 #include "gpu/config/gpu_switches.h"
 #include "gpu/config/gpu_util.h"
 #include "gpu/ipc/common/gpu_memory_buffer_support.h"
 #include "gpu/ipc/service/gpu_config.h"
 #include "gpu/ipc/service/gpu_memory_buffer_factory.h"
 #include "ui/events/platform/platform_event_source.h"
 #include "ui/gl/gl_context.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_surface.h"
 #include "ui/gl/gl_switches.h"
 #include "ui/gl/gpu_switching_manager.h"
 
+#if defined(OS_POSIX)
+#include <dlfcn.h>
+#endif
+
 #if defined(OS_WIN)
 #include <dwmapi.h>
 #include <windows.h>
 #endif
 
 #if defined(OS_ANDROID)
 #include "base/trace_event/memory_dump_manager.h"
 #include "components/tracing/graphics_memory_dump_provider_android.h"
 #endif
 
@@ skipping 418 matching lines @@
   {
     TRACE_EVENT0("gpu", "Warm up rand");
     // Warm up the random subsystem, which needs to be done pre-sandbox on all
     // platforms.
     (void) base::RandUint64();
   }
 
 #if defined(OS_WIN)
   media::DXVAVideoDecodeAccelerator::PreSandboxInitialization();
 #endif
+
+#if defined(OS_LINUX)
+  if (command_line.HasSwitch(switches::kGpuSandboxStartEarly)) {
+    // XXX: move all above code to the new GpuProcessPolicyEarlySandbox.
+
+    // uname is used from GpuControlList when calling
+    // gpu::ApplyGpuDriverBugWorkarounds.
+    base::SysInfo::OperatingSystemVersion();
+
+    // Cannot use base::LoadNativeLibrary because it uses RTLD_LAZY.
+    // We want to avoid the situation where a required symbol is loaded
+    // after the sandbox is ON. So load all symbols now.
+    // XXX: Instead of the library name above, uses:
+    // ui/gl/gl_implementation_x11.cc::kGLLibraryName, kGLESv2LibraryName, ...
+    dlopen("libglapi.so", RTLD_NOW|RTLD_GLOBAL|RTLD_NODELETE);
+    dlopen("libGL.so", RTLD_NOW|RTLD_GLOBAL|RTLD_NODELETE);
+
+    // XXX: find a way to determine when we know we are going to use llvmpipe
+    // driver.
+    dlopen("dri/swrast_dri.so", RTLD_NOW|RTLD_GLOBAL|RTLD_NODELETE);

[Ken Russell (switch to Gerrit), 2016/05/04 20:36:17]

Yes, this is not acceptable to commit in its current form.

If you can't call GLSurface::InitializeOneOff() before initializing the sandbox
because the driver starts threads, and you can't call it after initializing the
sandbox because you can't touch the filesystem afterward, that's a problem.

I think you should come up with some general code which will traverse the
link-time dependencies of the OpenGL-related shared objects you need, dlopen'ing
each one. Would that solve the problem of hardcoding these shared library names?

+  }
+#endif
+
   return true;
 }
 
 #if !defined(OS_MACOSX)
 bool CollectGraphicsInfo(gpu::GPUInfo& gpu_info) {
   TRACE_EVENT0("gpu,startup", "Collect Graphics Info");
 
   bool res = true;
   gpu::CollectInfoResult result = gpu::CollectContextGraphicsInfo(&gpu_info);
   switch (result) {
@@ skipping 116 matching lines @@
     return true;
   }
 
   return false;
 }
 #endif  // defined(OS_WIN)
 
 }  // namespace.
 
 }  // namespace content