Add a new driver bug workaround SANDBOX_START_EARLY

content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.h"
 
 #include <dlfcn.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <sys/socket.h>
@@ skipping 39 matching lines @@
 
 inline bool IsArchitectureArm() {
 #if defined(__arm__) || defined(__aarch64__)
   return true;
 #else
   return false;
 #endif
 }
 
 void AddArmMaliGpuWhitelist(std::vector<BrokerFilePermission>* permissions) {
+  // XXX: Generalize CrosArmGpuProcessPolicy to a new

[Ken Russell (switch to Gerrit), 2016/05/04 20:36:17]

TODO(j.isorce@samsung.com) instead of XXX, here and below

+  // GpuProcessPolicyEarlySandbox and move that part to IsArchitectureArm()
+
   // Device file needed by the ARM GPU userspace.
   static const char kMali0Path[] = "/dev/mali0";
 
   // Image processor used on ARM platforms.
   static const char kDevImageProc0Path[] = "/dev/image-proc0";
 
   permissions->push_back(BrokerFilePermission::ReadWrite(kMali0Path));
   permissions->push_back(BrokerFilePermission::ReadWrite(kDevImageProc0Path));
 }
 
 void AddArmGpuWhitelist(std::vector<BrokerFilePermission>* permissions) {
+  // XXX: Generalize CrosArmGpuProcessPolicy to a new
+  // GpuProcessPolicyEarlySandbox and move that part to IsArchitectureArm()
   // On ARM we're enabling the sandbox before the X connection is made,
   // so we need to allow access to |.Xauthority|.
   static const char kXAuthorityPath[] = "/home/chronos/.Xauthority";
   static const char kLdSoCache[] = "/etc/ld.so.cache";
 
   // Files needed by the ARM GPU userspace.
   static const char kLibGlesPath[] = "/usr/lib/libGLESv2.so.2";
   static const char kLibEglPath[] = "/usr/lib/libEGL.so.1";
 
   permissions->push_back(BrokerFilePermission::ReadOnly(kXAuthorityPath));
@@ skipping 71 matching lines @@
 }
 
 bool CrosArmGpuProcessPolicy::PreSandboxHook() {
   DCHECK(IsChromeOS() && IsArchitectureArm());
   // Create a new broker process.
   DCHECK(!broker_process());
 
   // Add ARM-specific files to whitelist in the broker.
   std::vector<BrokerFilePermission> permissions;
 
+  // XXX: Generalize CrosArmGpuProcessPolicy to a new
+  // GpuProcessPolicyEarlySandbox and move that part to IsArchitectureArm()
   AddArmGpuWhitelist(&permissions);
   InitGpuBrokerProcess(CrosArmGpuBrokerProcessPolicy::Create, permissions);
 
   const int dlopen_flag = RTLD_NOW | RTLD_GLOBAL | RTLD_NODELETE;
 
+  // XXX
   // Preload the Mali library.
   dlopen("/usr/lib/libmali.so", dlopen_flag);
   // Preload the Tegra V4L2 (video decode acceleration) library.
   dlopen("/usr/lib/libtegrav4l2.so", dlopen_flag);
   // Resetting errno since platform-specific libraries will fail on other
   // platforms.
   errno = 0;
 
   return true;
 }
 
 }  // namespace content