Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 1542003003: Revert "dart2js: Initial implementation of inlining." (Closed)

Created:
5 years ago by Kevin Millikin (Google)
Modified:
5 years ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "dart2js: Initial implementation of inlining." This reverts commit d63053fea8731d2fb380022c1c3d296489d1c017. Reverted due to test failures for compiler expected output. Those tests need to be rebaselined to reflect the effects of inlining. TBR=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/75eb350abc9adaf86686dc65a52eafaeb4283e30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -1046 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_fragment.dart View 1 chunk +5 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 12 chunks +48 lines, -451 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 3 chunks +5 lines, -12 lines 0 comments Download
D pkg/compiler/lib/src/cps_ir/inline.dart View 1 chunk +0 lines, -495 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimizers.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 3 chunks +39 lines, -41 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 5 chunks +7 lines, -17 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 4 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Kevin Millikin (Google)
5 years ago (2015-12-22 12:48:31 UTC) #1
Kevin Millikin (Google)
Committed patchset #1 (id:1) manually as 75eb350abc9adaf86686dc65a52eafaeb4283e30 (presubmit successful).
5 years ago (2015-12-22 12:48:48 UTC) #3
Bill Hesse
5 years ago (2015-12-22 14:19:03 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698