Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ExperimentalFeatures.h.tmpl

Issue 1541983003: Force all experiment enabled checks to use ExperimentalFeatures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/templates/ExperimentalFeatures.h.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/ExperimentalFeatures.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ExperimentalFeatures.h.tmpl
index d353b025985972828c087c8d59f9b5595ea39dad..c44d07b7d02995a36959428ae428c54182c20da3 100644
--- a/third_party/WebKit/Source/build/scripts/templates/ExperimentalFeatures.h.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/ExperimentalFeatures.h.tmpl
@@ -12,18 +12,25 @@ namespace blink {
class ExecutionContext;
// A class that stores dynamic tests for experimental features which can be
-// enabled through the experimental framwork via API keys.
+// enabled through the experimental framework via API keys.
class CORE_EXPORT ExperimentalFeatures {
public:
{% for feature in features %}
{% if feature.api_name %}
static bool {{feature.first_lowered_name}}Enabled(ExecutionContext* executionContext, String& errorMessage);
+ static bool {{feature.first_lowered_name}}Enabled(ExecutionContext* executionContext);
{% endif %}
{% endfor %}
private:
ExperimentalFeatures() { }
+
+ {% for feature in features %}
+ {% if feature.api_name %}
+ static bool {{feature.first_lowered_name}}EnabledImpl(ExecutionContext* executionContext, String* errorMessage);
+ {% endif %}
+ {% endfor %}
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698