Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/ExperimentalFeatures.h.tmpl

Issue 1541983003: Force all experiment enabled checks to use ExperimentalFeatures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments to explain class design and code generation Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% from 'macros.tmpl' import license %} 1 {% from 'macros.tmpl' import license %}
2 {{license()}} 2 {{license()}}
3 3
4 #ifndef ExperimentalFeatures_h 4 #ifndef ExperimentalFeatures_h
5 #define ExperimentalFeatures_h 5 #define ExperimentalFeatures_h
6 6
7 #include "core/CoreExport.h" 7 #include "core/CoreExport.h"
8 #include "wtf/text/WTFString.h" 8 #include "wtf/text/WTFString.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 class ExecutionContext; 12 class ExecutionContext;
13 13
14 // A class that stores dynamic tests for experimental features which can be 14 // A class that stores dynamic tests for experimental features which can be
15 // enabled through the experimental framwork via API keys. 15 // enabled through the experimental framework via API keys.
16 16
17 class CORE_EXPORT ExperimentalFeatures { 17 class CORE_EXPORT ExperimentalFeatures {
18 public: 18 public:
19 {% for feature in features %} 19 {% for feature in features %}
20 {% if feature.api_name %} 20 {% if feature.api_name %}
21 static bool {{feature.first_lowered_name}}Enabled(ExecutionContext* executio nContext, String& errorMessage); 21 static bool {{feature.first_lowered_name}}Enabled(ExecutionContext* executio nContext, String& errorMessage);
22 static bool {{feature.first_lowered_name}}Enabled(ExecutionContext* executio nContext);
22 {% endif %} 23 {% endif %}
23 {% endfor %} 24 {% endfor %}
24 25
25 private: 26 private:
26 ExperimentalFeatures() { } 27 ExperimentalFeatures() { }
28
29 {% for feature in features %}
30 {% if feature.api_name %}
31 static bool {{feature.first_lowered_name}}EnabledImpl(ExecutionContext* exec utionContext, String* errorMessage);
32 {% endif %}
33 {% endfor %}
27 }; 34 };
28 35
29 } // namespace blink 36 } // namespace blink
30 37
31 #endif // ExperimentalFeatures_h 38 #endif // ExperimentalFeatures_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698