Force all experiment enabled checks to use ExperimentalFeatures

third_party/WebKit/Source/build/scripts/templates/ExperimentalFeatures.cpp.tmpl

 {% from 'macros.tmpl' import license %}
 {{license()}}
 
 #include "core/experiments/ExperimentalFeatures.h"
 
 #include "core/experiments/Experiments.h"
 #include "platform/RuntimeEnabledFeatures.h"
 
 namespace blink {
 {% for feature in features %}
 {% if feature.api_name %}
 
 // static
 bool ExperimentalFeatures::{{feature.first_lowered_name}}Enabled(ExecutionContext* executionContext, String& errorMessage) {
+    return {{feature.first_lowered_name}}EnabledImpl(executionContext, &errorMessage);
+}
+
+// static
+bool ExperimentalFeatures::{{feature.first_lowered_name}}Enabled(ExecutionContext* executionContext) {
+    return {{feature.first_lowered_name}}EnabledImpl(executionContext, nullptr);
+}
+{% endif %}
+{% endfor %}

[iclelland, 2016/01/08 15:11:28]

Why the separate loop? Couldn't the next function definition go before the {%
endif %}?

[chasej, 2016/01/08 17:37:06]

The separate for loops are to match the declaration order in
ExperimentalFeatures.h.  That is, the two xxxEnabled() methods for each feature
are public, and declared first.  Followed by the declaration of all the
xxxEnabledImpl() private methods.

[iclelland, 2016/01/08 17:59:38]

Acknowledged.

+
+{% for feature in features %}
+{% if feature.api_name %}
+
+// static
+bool ExperimentalFeatures::{{feature.first_lowered_name}}EnabledImpl(ExecutionContext* executionContext, String* errorMessage) {
     if (RuntimeEnabledFeatures::{{feature.first_lowered_name}}Enabled())
         return true;
     return Experiments::isApiEnabled(executionContext, "{{feature.api_name}}", errorMessage);
 }
 {% endif %}
 {% endfor %}
 
 } // namespace blink