Add tileSKP option to nanobench

bench/SKPBench.cpp

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SKPBench.h"
 #include "SkCommandLineFlags.h"
 #include "SkMultiPictureDraw.h"
 #include "SkSurface.h"
 
 #if SK_SUPPORT_GPU
 #include "GrContext.h"
 #endif
 
+#include <stdlib.h>
+
+DEFINE_bool(tileSKP, true, "Tile skp benches?");
+
 // These CPU tile sizes are not good per se, but they are similar to what Chrome uses.
 DEFINE_int32(CPUbenchTileW, 256, "Tile width  used for CPU SKP playback.");
 DEFINE_int32(CPUbenchTileH, 256, "Tile height used for CPU SKP playback.");
 
 DEFINE_int32(GPUbenchTileW, 1600, "Tile width  used for GPU SKP playback.");
 DEFINE_int32(GPUbenchTileH, 512, "Tile height used for GPU SKP playback.");
 
 SKPBench::SKPBench(const char* name, const SkPicture* pic, const SkIRect& clip, SkScalar scale,
                    bool useMultiPictureDraw, bool doLooping)
     : fPic(SkRef(pic))
     , fClip(clip)
     , fScale(scale)
     , fName(name)
     , fUseMultiPictureDraw(useMultiPictureDraw)
     , fDoLooping(doLooping) {
     fUniqueName.printf("%s_%.2g", name, scale);  // Scale makes this unqiue for perf.skia.org traces.
     if (useMultiPictureDraw) {
+        if (!FLAGS_tileSKP) {
+            SkDebugf("Tried to use SkMultiPictureDraw with a non-tiled SKP. Aborting. "
+                     "(Please use --mpd false.)");
+            exit(-1);
+        }
         fUniqueName.append("_mpd");
     }
 }
 
 SKPBench::~SKPBench() {
     for (int i = 0; i < fSurfaces.count(); ++i) {
         fSurfaces[i]->unref();
     }
 }
 
 const char* SKPBench::onGetName() {
     return fName.c_str();
 }
 
 const char* SKPBench::onGetUniqueName() {
     return fUniqueName.c_str();
 }
 
 void SKPBench::onPerCanvasPreDraw(SkCanvas* canvas) {
+    if (!FLAGS_tileSKP) {
+        return;
+    }
+
     SkIRect bounds;
     SkAssertResult(canvas->getClipDeviceBounds(&bounds));
 
     const bool gpu = canvas->getGrContext() != nullptr;
     int tileW = gpu ? FLAGS_GPUbenchTileW : FLAGS_CPUbenchTileW,
         tileH = gpu ? FLAGS_GPUbenchTileH : FLAGS_CPUbenchTileH;
 
     tileW = SkTMin(tileW, bounds.width());
     tileH = SkTMin(tileH, bounds.height());
 
@@ skipping 17 matching lines @@
             clip.offset(-SkIntToScalar(tileRect.fLeft), -SkIntToScalar(tileRect.fTop));
             fSurfaces.top()->getCanvas()->clipRect(clip);
 
             fSurfaces.top()->getCanvas()->setMatrix(canvas->getTotalMatrix());
             fSurfaces.top()->getCanvas()->scale(fScale, fScale);
         }
     }
 }
 
 void SKPBench::onPerCanvasPostDraw(SkCanvas* canvas) {
+    if (!FLAGS_tileSKP) {
+        return;
+    }
+
     // Draw the last set of tiles into the master canvas in case we're
     // saving the images
     for (int i = 0; i < fTileRects.count(); ++i) {
         SkAutoTUnref<SkImage> image(fSurfaces[i]->newImageSnapshot());
         canvas->drawImage(image,
                           SkIntToScalar(fTileRects[i].fLeft), SkIntToScalar(fTileRects[i].fTop));
         SkSafeSetNull(fSurfaces[i]);
     }
 
     fSurfaces.rewind();
     fTileRects.rewind();
 }
 
 bool SKPBench::isSuitableFor(Backend backend) {
     return backend != kNonRendering_Backend;
 }
 
 SkIPoint SKPBench::onGetSize() {
     return SkIPoint::Make(fClip.width(), fClip.height());
 }
 
 void SKPBench::onDraw(int loops, SkCanvas* canvas) {
     SkASSERT(fDoLooping || 1 == loops);
-    if (fUseMultiPictureDraw) {
-        for (int i = 0; i < loops; i++) {
+    while (1) {
+        if (!FLAGS_tileSKP) {
+            this->drawPicture(canvas);
+        } else if (fUseMultiPictureDraw) {
             this->drawMPDPicture();
+        } else {
+            this->drawPictureTiled();
         }
-    } else {
-        for (int i = 0; i < loops; i++) {
-            this->drawPicture();
+        if (0 == --loops) {
+            break;
         }
+#if SK_SUPPORT_GPU
+        // Ensure the GrContext doesn't batch across draw loops.

[bsalomon, 2015/12/22 17:04:25]

It seems like now we will not flush after the last loop.

Also, the previous code only flushes after a set of loops. The comment is kind
of ambiguous so I can't tell if that was intentional or not. I'd kind of like
Josh to weigh in but he won't be back in the office until 12/28.

[Chris Dalton, 2015/12/22 18:47:05]

Oops :-\ the previous code was wrong.
I added that flushing code a couple months back:
https://codereview.chromium.org/1427533002/ . Before, it didn't flush at all.
The idea was that without the flushing, Gr could cheat and reorder/batch
together draws that originated from different loops.

I purposely removed the flush after the final loop because nanobench itself
appears to take care of it:


    canvas = target->beginTiming(canvas);
    bench->draw(loops, canvas);
    if (canvas) {
        canvas->flush();
    }
    target->endTiming();


(Is it possible for "canvas->flush()" to not flush the GrContext?)


Do you think I should split this into two different commits? One to fix the
flushing thing and one to add the --tileSKP flag?

+        if (GrContext* context = canvas->getGrContext()) {
+            context->flush();
+        }
+#endif
     }
-#if SK_SUPPORT_GPU
-    // Ensure the GrContext doesn't batch across draw loops.
-    if (GrContext* context = canvas->getGrContext()) {
-        context->flush();
-    }
-#endif
+}
+
+void SKPBench::drawPicture(SkCanvas* canvas) {
+    canvas->drawPicture(fPic);
 }
 
 void SKPBench::drawMPDPicture() {
     SkMultiPictureDraw mpd;
 
     for (int j = 0; j < fTileRects.count(); ++j) {
         SkMatrix trans;
         trans.setTranslate(-fTileRects[j].fLeft/fScale,
                            -fTileRects[j].fTop/fScale);
         mpd.add(fSurfaces[j]->getCanvas(), fPic, &trans);
     }
 
     mpd.draw();
 
     for (int j = 0; j < fTileRects.count(); ++j) {
         fSurfaces[j]->getCanvas()->flush();
     }
 }
 
-void SKPBench::drawPicture() {
+void SKPBench::drawPictureTiled() {
     for (int j = 0; j < fTileRects.count(); ++j) {
         const SkMatrix trans = SkMatrix::MakeTrans(-fTileRects[j].fLeft / fScale,
                                                    -fTileRects[j].fTop / fScale);
         fSurfaces[j]->getCanvas()->drawPicture(fPic, &trans, nullptr);
     }
 
     for (int j = 0; j < fTileRects.count(); ++j) {
         fSurfaces[j]->getCanvas()->flush();
     }
 }
@@ skipping 31 matching lines @@
     context->freeGpuResources();
     context->resetContext();
     context->getGpu()->resetShaderCacheForTesting();
     draw_pic_for_stats(canvas, context, fPic, keys, values, "first_frame");
 
     // draw second frame
     draw_pic_for_stats(canvas, context, fPic, keys, values, "second_frame");
 
 #endif
 }