Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1541933004: remove unused SkCullPoints (Closed)

Created:
5 years ago by reed1
Modified:
4 years, 11 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove unused SkCullPoints need to remove file references from chrome before landing this https://codereview.chromium.org/1547603002# BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1541933004 TBR=scroggo Committed: https://skia.googlesource.com/skia/+/b39f39f5ccb39786e9325cdf08a5dc52ef78544c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -485 lines) Patch
M gm/hittestpath.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/utils.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
D include/utils/SkCullPoints.h View 1 chunk +0 lines, -71 lines 0 comments Download
D samplecode/SampleCull.cpp View 1 chunk +0 lines, -197 lines 0 comments Download
M samplecode/SampleFillType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M samplecode/SampleWritePixels.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D src/utils/SkCullPoints.cpp View 1 chunk +0 lines, -211 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541933004/1
5 years ago (2015-12-22 01:29:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-22 01:44:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541933004/1
5 years ago (2015-12-22 02:36:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b39f39f5ccb39786e9325cdf08a5dc52ef78544c
5 years ago (2015-12-22 02:37:23 UTC) #12
scroggo
4 years, 11 months ago (2016-01-04 13:38:43 UTC) #14
Message was sent while issue was closed.
lgtm. Android does not use SkCullPoints

Powered by Google App Engine
This is Rietveld 408576698