third_party/WebKit/Source/core/svg/SVGSVGElement.cpp - Issue 1541923002: Make SVGElement::propertyFromAttribute return raw pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

Issue 1541923002: Make SVGElement::propertyFromAttribute return raw pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

index 089c8b4d37c41c8022db9f2789517bb386224fdb..aa02b54db57c0314b9ddeedd31fcd102cc2b8503 100644

--- a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

@@ -245,7 +245,7 @@ bool SVGSVGElement::isPresentationAttributeWithSVGDOM(const QualifiedName& attrN

void SVGSVGElement::collectStyleForPresentationAttribute(const QualifiedName& name, const AtomicString& value, MutableStylePropertySet* style)

{

- RefPtrWillBeRawPtr<SVGAnimatedPropertyBase> property = propertyFromAttribute(name);

+ SVGAnimatedPropertyBase* property = propertyFromAttribute(name);

if (property == m_x) {

addPropertyToPresentationAttributeStyle(style, CSSPropertyX, m_x->currentValue()->asCSSPrimitiveValue());

} else if (property == m_y) {

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGRectElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »