third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp - Issue 1541923002: Make SVGElement::propertyFromAttribute return raw pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp

Issue 1541923002: Make SVGElement::propertyFromAttribute return raw pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/StringKeyframe.cpp ('k') | third_party/WebKit/Source/core/svg/SVGCircleElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp b/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp

index 18b00eda145af1fef763398ed80d8440de7b1c49..e625e7eac3439353fe9a85a0ebf444e7ff1fa682 100644

--- a/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp

@@ -169,8 +169,7 @@ void setAnimatedValueOnAllTargetProperties(const SVGElementInstances& list, cons

RefPtrWillBeRawPtr<SVGPropertyBase> value = passValue;

for (SVGElement* elementInstance : list) {

- RefPtrWillBeRawPtr<SVGAnimatedPropertyBase> animatedProperty = elementInstance->propertyFromAttribute(attributeName);

- if (animatedProperty)

+ if (SVGAnimatedPropertyBase* animatedProperty = elementInstance->propertyFromAttribute(attributeName))

animatedProperty->setAnimatedValue(value);

}

@@ -204,8 +203,7 @@ void SVGAnimatedTypeAnimator::stopAnimValAnimation(const SVGElementInstances& li

SVGElement::InstanceUpdateBlocker blocker(m_contextElement);

for (SVGElement* elementInstance : list) {

- RefPtrWillBeRawPtr<SVGAnimatedPropertyBase> animatedProperty = elementInstance->propertyFromAttribute(m_animatedProperty->attributeName());

- if (animatedProperty)

+ if (SVGAnimatedPropertyBase* animatedProperty = elementInstance->propertyFromAttribute(m_animatedProperty->attributeName()))

animatedProperty->animationEnded();

}