Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGUseElement.cpp

Issue 1541923002: Make SVGElement::propertyFromAttribute return raw pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGSVGElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
5 * Copyright (C) 2011 Torch Mobile (Beijing) Co. Ltd. All rights reserved. 5 * Copyright (C) 2011 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
6 * Copyright (C) 2012 University of Szeged 6 * Copyright (C) 2012 University of Szeged
7 * Copyright (C) 2012 Renata Hodovan <reni@webkit.org> 7 * Copyright (C) 2012 Renata Hodovan <reni@webkit.org>
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 180
181 bool SVGUseElement::isPresentationAttributeWithSVGDOM(const QualifiedName& attrN ame) const 181 bool SVGUseElement::isPresentationAttributeWithSVGDOM(const QualifiedName& attrN ame) const
182 { 182 {
183 if (attrName == SVGNames::xAttr || attrName == SVGNames::yAttr) 183 if (attrName == SVGNames::xAttr || attrName == SVGNames::yAttr)
184 return true; 184 return true;
185 return SVGGraphicsElement::isPresentationAttributeWithSVGDOM(attrName); 185 return SVGGraphicsElement::isPresentationAttributeWithSVGDOM(attrName);
186 } 186 }
187 187
188 void SVGUseElement::collectStyleForPresentationAttribute(const QualifiedName& na me, const AtomicString& value, MutableStylePropertySet* style) 188 void SVGUseElement::collectStyleForPresentationAttribute(const QualifiedName& na me, const AtomicString& value, MutableStylePropertySet* style)
189 { 189 {
190 RefPtrWillBeRawPtr<SVGAnimatedPropertyBase> property = propertyFromAttribute (name); 190 SVGAnimatedPropertyBase* property = propertyFromAttribute(name);
191 if (property == m_x) 191 if (property == m_x)
192 addPropertyToPresentationAttributeStyle(style, CSSPropertyX, m_x->curren tValue()->asCSSPrimitiveValue()); 192 addPropertyToPresentationAttributeStyle(style, CSSPropertyX, m_x->curren tValue()->asCSSPrimitiveValue());
193 else if (property == m_y) 193 else if (property == m_y)
194 addPropertyToPresentationAttributeStyle(style, CSSPropertyY, m_y->curren tValue()->asCSSPrimitiveValue()); 194 addPropertyToPresentationAttributeStyle(style, CSSPropertyY, m_y->curren tValue()->asCSSPrimitiveValue());
195 else 195 else
196 SVGGraphicsElement::collectStyleForPresentationAttribute(name, value, st yle); 196 SVGGraphicsElement::collectStyleForPresentationAttribute(name, value, st yle);
197 } 197 }
198 198
199 void SVGUseElement::svgAttributeChanged(const QualifiedName& attrName) 199 void SVGUseElement::svgAttributeChanged(const QualifiedName& attrName)
200 { 200 {
(...skipping 614 matching lines...) Expand 10 before | Expand all | Expand 10 after
815 815
816 if (m_resource) 816 if (m_resource)
817 m_resource->removeClient(this); 817 m_resource->removeClient(this);
818 818
819 m_resource = resource; 819 m_resource = resource;
820 if (m_resource) 820 if (m_resource)
821 m_resource->addClient(this); 821 m_resource->addClient(this);
822 } 822 }
823 823
824 } 824 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGSVGElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698