Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGRectElement.cpp

Issue 1541923002: Make SVGElement::propertyFromAttribute return raw pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 { 106 {
107 if (attrName == SVGNames::xAttr || attrName == SVGNames::yAttr 107 if (attrName == SVGNames::xAttr || attrName == SVGNames::yAttr
108 || attrName == SVGNames::widthAttr || attrName == SVGNames::heightAttr 108 || attrName == SVGNames::widthAttr || attrName == SVGNames::heightAttr
109 || attrName == SVGNames::rxAttr || attrName == SVGNames::ryAttr) 109 || attrName == SVGNames::rxAttr || attrName == SVGNames::ryAttr)
110 return true; 110 return true;
111 return SVGGeometryElement::isPresentationAttributeWithSVGDOM(attrName); 111 return SVGGeometryElement::isPresentationAttributeWithSVGDOM(attrName);
112 } 112 }
113 113
114 void SVGRectElement::collectStyleForPresentationAttribute(const QualifiedName& n ame, const AtomicString& value, MutableStylePropertySet* style) 114 void SVGRectElement::collectStyleForPresentationAttribute(const QualifiedName& n ame, const AtomicString& value, MutableStylePropertySet* style)
115 { 115 {
116 RefPtrWillBeRawPtr<SVGAnimatedPropertyBase> property = propertyFromAttribute (name); 116 SVGAnimatedPropertyBase* property = propertyFromAttribute(name);
117 if (property == m_x) 117 if (property == m_x)
118 addPropertyToPresentationAttributeStyle(style, CSSPropertyX, m_x->curren tValue()->asCSSPrimitiveValue()); 118 addPropertyToPresentationAttributeStyle(style, CSSPropertyX, m_x->curren tValue()->asCSSPrimitiveValue());
119 else if (property == m_y) 119 else if (property == m_y)
120 addPropertyToPresentationAttributeStyle(style, CSSPropertyY, m_y->curren tValue()->asCSSPrimitiveValue()); 120 addPropertyToPresentationAttributeStyle(style, CSSPropertyY, m_y->curren tValue()->asCSSPrimitiveValue());
121 else if (property == m_width) 121 else if (property == m_width)
122 addPropertyToPresentationAttributeStyle(style, CSSPropertyWidth, m_width ->currentValue()->asCSSPrimitiveValue()); 122 addPropertyToPresentationAttributeStyle(style, CSSPropertyWidth, m_width ->currentValue()->asCSSPrimitiveValue());
123 else if (property == m_height) 123 else if (property == m_height)
124 addPropertyToPresentationAttributeStyle(style, CSSPropertyHeight, m_heig ht->currentValue()->asCSSPrimitiveValue()); 124 addPropertyToPresentationAttributeStyle(style, CSSPropertyHeight, m_heig ht->currentValue()->asCSSPrimitiveValue());
125 else if (property == m_rx) 125 else if (property == m_rx)
126 addPropertyToPresentationAttributeStyle(style, CSSPropertyRx, m_rx->curr entValue()->asCSSPrimitiveValue()); 126 addPropertyToPresentationAttributeStyle(style, CSSPropertyRx, m_rx->curr entValue()->asCSSPrimitiveValue());
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 || m_rx->currentValue()->isRelative() 164 || m_rx->currentValue()->isRelative()
165 || m_ry->currentValue()->isRelative(); 165 || m_ry->currentValue()->isRelative();
166 } 166 }
167 167
168 LayoutObject* SVGRectElement::createLayoutObject(const ComputedStyle&) 168 LayoutObject* SVGRectElement::createLayoutObject(const ComputedStyle&)
169 { 169 {
170 return new LayoutSVGRect(this); 170 return new LayoutSVGRect(this);
171 } 171 }
172 172
173 } // namespace blink 173 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGPathElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGSVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698